This repository has been archived by the owner on May 10, 2023. It is now read-only.
fix: do not use locale prefixed URLs for login/logout #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelKohler
pushed a commit
that referenced
this pull request
Oct 31, 2021
# [2.12.0](v2.11.3...v2.12.0) (2021-10-31) ### Bug Fixes * always link to localized URL (fixes [#504](#504)) ([#512](#512)) ([6e66528](6e66528)) * do not use locale prefixed URLs for login/logout ([#506](#506)) ([02053a4](02053a4)) * fix empty page after reviewing last sentence (fixes [#498](#498)) ([728f429](728f429)) * fix typo in sc-lang-info-left-for-you ([#515](#515)) ([313273f](313273f)) * fix upperkey keys not working in Review (fixes [#487](#487)) ([#508](#508)) ([6c3a073](6c3a073)) * make duplicate sentences use plural rules ([#511](#511)) ([ab2c696](ab2c696)) * move LocalizationProvider outwards to not request language on every page navigation ([6a5967e](6a5967e)) * only expose error codes ([2114b38](2114b38)) * show 'Add more sentences' link in stats when no more to review for user ([#516](#516)) ([ae9f1cf](ae9f1cf)) * show native language name only in stats (issue [#492](#492)) ([#514](#514)) ([0086c64](0086c64)) * slight font adjustments ([#505](#505)) ([25ca2e0](25ca2e0)) ### Features * localization: extract English strings into FTL file ([#507](#507)) ([6d64afb](6d64afb)), closes [#501](#501)
|
🎉 This PR is included in version 2.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not use locale prefixed URLs for login and logout. The redirect will be to EN anyway, and we do not have any localizeable content in the success cases anyway, those are just redirects.
For the failed login case, we don't need a param, as we can negotiate the language appropriately when loading the component. Additionally I wrapped the Login Failure component into the PageContainer, so we don't lose the menu. This was a bug I recently introduced.