Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beast fails to initialize model when the number of states is different. #15

Open
J-Moravec opened this issue Apr 27, 2021 · 0 comments
Open

Comments

@J-Moravec
Copy link

When using the ordinal model and ordinal data with a different number of states, beast fails to initialize the model giving -infinite likelihood.

This is an input user error and should be caught during the model verification stage (such as when the sum of frequencies is checked) and communicated with an appropriate error.

During creating a sample test case with short sequences, beast even managed to run (although gave a few "incorrect likelihood was calculated" errors), this should not have happened.

Suggested fix: Additional assert/check that the number of states in the model agrees with the data.

Sample example: XML with randomly generated sequences and, to my best knowledge, vanilla ordinal model specification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant