Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delete-artifact in Automatus workflows #11468

Conversation

vojtapolasek
Copy link
Collaborator

@vojtapolasek vojtapolasek commented Jan 24, 2024

Description:

  • add Github token to delete-artifact actions
  • specify permissions explicitly so that the delete-artifact can actually delete the artifact

Rationale:

Testing hints:

  • clone this PR and create a new PR while submitting some change to a rule remediation
  • or try to modify already existing PR which exhibits the problem with Automatus workflows and failing delete-artifact action according to this PR

Copy link

github-actions bot commented Jan 24, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@vojtapolasek vojtapolasek force-pushed the try_automatus_permissions_fix branch 3 times, most recently from 61a9c8c to b2bc2ae Compare January 24, 2024 14:18
because new version of delete-artifact requires it
@vojtapolasek vojtapolasek force-pushed the try_automatus_permissions_fix branch from b2bc2ae to 8b05f87 Compare January 24, 2024 14:36
Copy link

codeclimate bot commented Jan 24, 2024

Code Climate has analyzed commit 8b05f87 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.5% (0.0% change).

View more on Code Climate.

@vojtapolasek vojtapolasek changed the title DO NOT MERGE: fix delete-artifact in Automatus workflows Fix delete-artifact in Automatus workflows Jan 24, 2024
@vojtapolasek vojtapolasek added this to the 0.1.72 milestone Jan 24, 2024
@vojtapolasek vojtapolasek added the Infrastructure Our content build system label Jan 24, 2024
@Mab879 Mab879 self-assigned this Jan 24, 2024
@Mab879
Copy link
Member

Mab879 commented Jan 24, 2024

I was unable see the fix on by test PR.

@vojtapolasek
Copy link
Collaborator Author

I am closing this PR, it will be probably superseded by #11482.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants