Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove missing-references ctest #12434

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

mildas
Copy link
Contributor

@mildas mildas commented Sep 27, 2024

Description:

Checking missing references has been implemented as /static-checks/rule-identifiers Contest test and is part of /static-checks CI check.

Rationale:

missing-references ctest was unnecessary complicated as it was Bash script calling build-scripts/profile_tool.py stats which is not intended as test but as a tool for obtaining various profile statistics.

Newly introduced test in Contest RHSecurityCompliance/contest#265 is easily extensible for new references, waive-able (via Contest waivers), and simpler.

Review Hints:

See CI checks that missing-references is not part of ctests and that /static-checks/rule-identifiers does what's expected (see link above and run in Testing Farm CentOS static-checks).

Checking missing references has been implemented as
/static-checks/rule-identifiers Contest test and is part of
/static-checks CI check.
@mildas mildas added the Test Suite Update in Test Suite. label Sep 27, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12434
This image was built from commit: d8dc1d3

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12434

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12434 make deploy-local

Copy link

codeclimate bot commented Sep 27, 2024

Code Climate has analyzed commit d8dc1d3 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.5% (0.0% change).

View more on Code Climate.

@mildas mildas added this to the 0.1.75 milestone Sep 27, 2024
@Mab879 Mab879 self-assigned this Sep 27, 2024
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Mab879 Mab879 merged commit 1845717 into ComplianceAsCode:master Sep 27, 2024
100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test Suite Update in Test Suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants