-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion for classification of the compositional constituants #61
Comments
Thanks @maweber-bia, I will discuss this with the team and get back to you during the week. I can see some points that we could agree on and incorporate in CDNO. |
Thanks @maweber-bia for posting this. Would you mind elaborating what is different between "real" and compositional? That might help us better model it. Ontologies allow for multi-inheritance, aka terms having multiple parents, so perhaps it is possible to represent thing from multiple perspectives. |
Keep in mind that we'll need to refactor the current dietary nutritional component hierarchy to remove any BFO role terms including vitamins and also plant secondary metabolite (which is also a role). It'd be best for this hierarchy to follow BFO and only contain independent continuants (entities). |
@kaiiam Sorry for misusing "real": actually, I mean something which is considered to be a nutrient= nutritive component I think that secondary plant metabolites should be considered as entities too (but perhaps there is the need to have the class renamed as phytochemical to be more generic ?) |
I'm just trying to understand here are you suggesting something like differentiating chemicals which are nutrients (has some sort of role in nutrition) from those compositional which are eaten but don't provide some sort of nutrition? Is that what you mean if not could you elaborate more so we can try to better model it.
simply because |
Edit in previous comment view it on github if using email. |
my response to your comments
--> yes, I was trying to suggest "differentiating chemicals which are nutrients (has some sort of role in nutrition) from those compositional which are eaten but don't provide some sort of nutrition"
--> please see the reference https://pubmed.ncbi.nlm.nih.gov/31769838/ |
Great thanks @maweber-bia! @CropStoreDb and @LilyAndres do you agree with the proposed change from I'm just the ontology engineer for the project, not a nutrition scientist, so I won't weigh in except to say that it'd good be too to have a generic high level representation of the intended concept preferably using terminology already accepted by the community. Also we need to not be using a BFO role descendant like |
Thanks @kaiiam and @maweber-bia. About the What we mentioned is that we were going to have plant secondary metabolite as a material entity and not as a role for now, but we mentioned that if CHEBI was interested in having it as a role, we would add it there. I think with the CDNO changing to "Compositional", we could change it to something different that could involve not only "plant" or "phyto", but other "secondary metabolites" from other organisms. See my quote from #29 "but maybe it can evolve to DNO including other nutritional components derived from other kingdoms and not only from plants." |
Yes, your right I tough it was a role class but it's our own CDNO class plant secondary metabolite so were good to keep it in the DNC hierarchy as it's a material entity. Sorry I missed that earlier disregard previous comments about needing to change it for the sake of making BFO correct.
If we have a new term that's more general than just plants to replace or add to the DNC we should do that, (and maybe depreciate this if needed). |
@maweber-bia thanks a lot for all your comments. We are trying to check if the hierarchies that you mentioned work for us, is good to mention that we created the CDNO framework, based on some information from the Food Composition Tables such as USDA, INFOODs and EuroFIR. For this reason, we might not be able to change the label from Here is the definition of "A material entity that is ingested and contributes to survival, growth, and development." For the other subclasses you mentioned. Are "nutrients", "micronutrients" and "macronutrients" considered as roles? If so, we probably want to describe them in the I think with the change of Crop DNO to Compositional DNO, we might need to look at special terms we had for plants eg:
@kaiiam Do you think ENVO would like to define this term? |
Hi, thank you for the answers. Please do not consider the term "component" in my hierarchy (it is my own top-level). If you consider "nutrient" as a role, then my question is now a little bit misleading. I will wait and see the decision about vitamins (#57 ) I just want to add that to me "plant dry matter" and "dry plant matter" are not the same things If "dry matter" is too generic, you can use "food dry matter" instead and then, plant dry matter is the dry matter content in plants (you can also have dry matter in other foods, this is a measurement of the dried sample where the moisture is not taken into account) ash + organic matter = 100% of dried sample. |
That's an annotation property from UBERON or PROV (the former) is the multi-species anatomy ontology, I don't see how this is relevant to us or something we should care/worry about. Component isn't defined in that annotation property, so we don't need to use the term. I assumed it was terminology used from the original framework if it's recognizable to people then it's probably worth keeping.
I don't think that's helpful to our purpose here. I'd vote for @maweber-bia's suggestion of using "food dry matter" instead. |
As the coverage of CDNO is now "Compositional Dietary Nutrition Ontology" I would suggest to clarify the current hierarchy which is "dietary nutritional component"
Actually, they are a mismatch between compositional constituents and "real" nutritional components.
I mean we can enlarge the coverage of this branch by renaming it "compositional constituent" and then distinguish between nutrient subclasses and other subclasses (see my suggestion below)
This is the direction I am taking in my own work. I would be happy if we could agree on this.
The text was updated successfully, but these errors were encountered: