Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pydantic dependency for ray>2.9 #1066

Closed
garrettwrong opened this issue Dec 12, 2023 · 2 comments
Closed

Update pydantic dependency for ray>2.9 #1066

garrettwrong opened this issue Dec 12, 2023 · 2 comments
Assignees
@garrettwrong
Labels
cleanup dependencies Pull requests that update a dependency file extern Relating to external changes good first issue Good for newcomers

Comments

@garrettwrong
Copy link
Collaborator

When Ray 2.9 is released across all relevant platforms we can consider requiring ray>2.9 and updating/removing the pydantic dependency. We do not use pydantic directly in ASPIRE.

See:

ray-project/ray#37019

Tentatively adding to v0.13.0 board. For v0.12.1 we are going with the workaround recommended by Ray devs at this time via #1065 .
@garrettwrong garrettwrong added good first issue Good for newcomers cleanup extern Relating to external changes dependencies Pull requests that update a dependency file labels Dec 12, 2023
@garrettwrong garrettwrong self-assigned this Feb 21, 2024
@garrettwrong
Copy link
Collaborator Author

Looks like ray is at 2.9.2 now. I'll prep a PR that update ray and pydantic versions.

@garrettwrong
Copy link
Collaborator Author

Ray has been updated in #1092, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garrettwrong garrettwrong

Labels
cleanup dependencies Pull requests that update a dependency file extern Relating to external changes good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@garrettwrong