Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actual Unit tests #131

Open
devinmatte opened this issue Jul 10, 2019 · 1 comment
Open

Actual Unit tests #131

devinmatte opened this issue Jul 10, 2019 · 1 comment

Comments

@devinmatte
Copy link
Member

devinmatte commented Jul 10, 2019

Lord how annoying it is to write tests, but this application and it's importance requires some basic unit tests. We should have edge cases tested against.

  • Underclassman tries to sign as upperclassman
  • Off Floor Underclassman tries to sign packet

We will also need some kind of mocking database system to create the logic for this

@mxmeinhold
Copy link
Collaborator

We have ldap mocked, and we can spin up a test db in ci. I think the only blocker is sso. Maybe we could add an argument to before_request to use a local moc? This would also be a solution for #233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants