Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specgen: add more tests, rename connector to specification #206

Merged
merged 13 commits into from
Nov 18, 2024
Merged

specgen: add more tests, rename connector to specification #206

merged 13 commits into from
Nov 18, 2024

Conversation

hariso
Copy link
Contributor

@hariso hariso commented Nov 14, 2024 •
edited
Loading

Description

  • Splits the current basic test into a couple of tests
  • Adds more tests
  • Adds comments
  • Fixes linting
  • Prints the numbers used in validation a bit prettier (previously: greater-than: 100.00000, now: greater-than: 100)

Related issues:

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@hariso hariso changed the title Specgen polishing Specgen: add more tests, comments, fix linter issues Nov 15, 2024
@hariso hariso marked this pull request as ready for review November 15, 2024 09:03
@hariso hariso requested a review from a team as a code owner November 15, 2024 09:03
@hariso hariso mentioned this pull request Nov 15, 2024
Open
15 tasks
@hariso hariso changed the title Specgen: add more tests, comments, fix linter issues specgen: add more tests, rename connector to specification Nov 15, 2024
@hariso hariso changed the base branch from lovro/specgen-spike to specgen November 15, 2024 09:56
@hariso hariso mentioned this pull request Nov 15, 2024
Merged
10 tasks
@hariso hariso force-pushed the haris/specgen-polishing branch from 58a5056 to b2839d8 Compare November 15, 2024 14:25
@raulb
Copy link
Member

raulb commented Nov 18, 2024

Looks like this test is failing :(

-- FAIL: TestTraverse (0.00s)
    --- FAIL: TestTraverse/struct_with_map_field (0.00s)
    ```

@hariso hariso requested a review from raulb November 18, 2024 14:25
@hariso
Copy link
Contributor Author

hariso commented Nov 18, 2024

Looks like this test is failing :(

-- FAIL: TestTraverse (0.00s)
    --- FAIL: TestTraverse/struct_with_map_field (0.00s)
    ```

The test is green now!

raulb
raulb approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hariso hariso merged commit f51b771 into specgen Nov 18, 2024
3 checks passed
@hariso hariso deleted the haris/specgen-polishing branch November 18, 2024 17:22
hariso added a commit that referenced this pull request Nov 28, 2024
@hariso
Author: Haris Osmanagic <haris@meroxa.io>
bafb76f 
Date:   Thu Nov 28 12:44:48 2024 +0100

    add open

commit 2705320
Author: Haris Osmanagic <haris@meroxa.io>
Date:   Thu Nov 28 11:21:36 2024 +0100

    destination_middleware_test.go

commit b3f8172
Author: Haris Osmanagic <haris@meroxa.io>
Date:   Thu Nov 28 10:08:22 2024 +0100

    fix source_test

commit 6a53d24
Author: Haris Osmanagic <haris@meroxa.io>
Date:   Thu Nov 28 10:02:23 2024 +0100

    fix source middleware

commit 6cf5795
Author: Haris Osmanagic <haris@meroxa.io>
Date:   Wed Nov 27 15:39:46 2024 +0100

    add test

commit be36d59
Author: Haris Osmanagic <haris@meroxa.io>
Date:   Wed Nov 20 16:01:29 2024 +0100

    fix source_middleware_test.go

commit abdb4b7
Author: Haris Osmanagic <haris@meroxa.io>
Date:   Wed Nov 20 12:54:48 2024 +0100

    fix DefaultDestinationMiddleware

commit b07a4b5
Author: Haris Osmanagic <haris@meroxa.io>
Date:   Wed Nov 20 12:50:00 2024 +0100

    linter

commit 727489f
Author: Haris Osmanagic <haris@meroxa.io>
Date:   Wed Nov 20 12:49:46 2024 +0100

    comments

commit 768c935
Author: Haris Osmanagic <haris@meroxa.io>
Date:   Wed Nov 20 12:46:33 2024 +0100

    add comment

commit d9f7f64
Author: Haris Osmanagic <haris@meroxa.io>
Date:   Wed Nov 20 12:42:57 2024 +0100

    fix test expectation

commit 9f5c6c2
Author: Haris Osmanagic <haris@meroxa.io>
Date:   Wed Nov 20 12:35:06 2024 +0100

    handle schema type

commit ddd70f5
Author: Haris Osmanagic <haris@meroxa.io>
Date:   Wed Nov 20 11:03:34 2024 +0100

    workaround for schema type, optional dest mw param, fix validation

commit fe751ca
Author: Haris Osmanagic <haris@meroxa.io>
Date:   Tue Nov 19 15:17:30 2024 +0100

    restructure

commit 7318263
Author: Haris Osmanagic <haris@meroxa.io>
Date:   Tue Nov 19 14:59:25 2024 +0100

    fix tests

commit 04e9fd4
Author: Haris Osmanagic <haris@meroxa.io>
Date:   Tue Nov 19 14:06:01 2024 +0100

    re-enable acceptance tests

commit c5174a6
Author: Haris Osmanagic <haris@meroxa.io>
Date:   Tue Nov 19 13:08:09 2024 +0100

    partial specs test

commit dcc08ed
Author: Haris Osmanagic <haris@meroxa.io>
Date:   Tue Nov 19 12:48:02 2024 +0100

    write yaml, overwrite existiang source and destination

commit 8af981f
Author: Haris Osmanagic <haris@meroxa.io>
Date:   Tue Nov 19 12:45:18 2024 +0100

    more tests, restructure

commit 1755bac
Author: Haris Osmanagic <haris@meroxa.io>
Date:   Tue Nov 19 12:37:09 2024 +0100

    revert changes to input file

commit dabaf2e
Author: Haris Osmanagic <haris@meroxa.io>
Date:   Mon Nov 18 19:12:42 2024 +0100

    update test

commit 2b4394a
Author: Haris Osmanagic <haris@meroxa.io>
Date:   Mon Nov 18 19:09:57 2024 +0100

    simplify

commit ab77011
Author: Haris Osmanagic <haris@meroxa.io>
Date:   Mon Nov 18 19:08:12 2024 +0100

    TestWriteAndCombine

commit f51b771
Author: Haris Osmanagić <haris@meroxa.io>
Date:   Mon Nov 18 18:22:24 2024 +0100

    specgen: add more tests, rename connector to specification (#206)

commit 07483f5
Author: Lovro Mažgon <lovro.mazgon@gmail.com>
Date:   Fri Nov 15 15:06:29 2024 +0100

    Specgen (#198)

    * specgen spike

    * start nicer rewrite of specgen

    * support for parsing builtin params

    * support for time.Duration

    * support types in different packages

    * support underlying type

    * better tests

    * specgen specification parsing and default overwriting

    * add support for destinations

    * fix test

    * add parsing and validation of config

    * adjust most destination tests

    ---------

    Co-authored-by: Haris Osmanagic <haris@meroxa.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulb raulb raulb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hariso @raulb