-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we move default writable paths to the uploads dir? #136
Comments
@mmcev106 I think this would be a good feature. My preferred method to maintain backward compatibility would be adding a setting that would allow the admin to change the base folder that the scss is loaded from and written to. Currently it is hardcoded into the theme folder. |
@mmcev106 this was partially updated in 2.1.1. The base dir for both SCSS and CSS files can now be set to the uploads or plugins folders as well as the base theme. The cache folder is still in the plugin but has been committed to repo and should not require creating in the future. |
Thanks very much @shadoath! Our IT team since wrote a script to update permissions for this plugin as part of the automated update process. I'll mention this in case they want to remove that process now that we have another option. |
Let me know what else can be done to improve the new base path, I don't think it is at the point I want yet. |
I think the cache folder needs to move to It generally seems bad for a plugin to modify its own folder; if it's possible to move the cache out of it, I think it should be done. |
Some WordPress deployments make plugin code read only for the web server user. In my installation I have to manually
chmod
the cache, error log, and compiled css every time the plugin is updated for my site to work properly. It seems like the appropriate solution would be to place any writable files in eitheruploads/wp-scss
directory, or perhapswp-content/wp-scss
. I considered creating a pull request to accomplish this, but wasn't sure of the preferred way to handle existing files.The text was updated successfully, but these errors were encountered: