Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Things to be reverted in time #7

Open
JamieDixon opened this issue Aug 31, 2017 · 0 comments
Open

Things to be reverted in time #7

JamieDixon opened this issue Aug 31, 2017 · 0 comments

Comments

@JamieDixon
Copy link

JamieDixon commented Aug 31, 2017

  1. packages/react-scripts/fixtures/kitchensink/src/features/webpack/assets/style.css

Need to uncomment /*@import '~normalize.css/normalize.css';*/ once we stop using postcss in V3. This is commented because we've told webpack to import all CSS from paths.appSrc + '/assets/stylesheets/common' which causes CRA e2e tests to fail because they can't find the normalize file as expected.

Test with: tasks/e2e-kitchensink.sh

  1. packages/react-scripts/fixtures/kitchensink/integration/webpack.test.js

Need to uncomment tests:

    it('css inclusion', async () => {
      const doc = await initDOM('css-inclusion');
    
      expect(
        doc.getElementsByTagName('style')[0].textContent.replace(/\s/g, '')
      ).to.match(/html\{/);
      expect(
        doc.getElementsByTagName('style')[1].textContent.replace(/\s/g, '')
      ).to.match(/#feature-css-inclusion\{background:.+;color:.+}/);
    });

This is part of the above change to fix CSS imports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant