-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BW6-633 curve #185
Add BW6-633 curve #185
Conversation
@yelhousni ha, vet / build fails with: |
We just need to add E24 (and E8) types to bls24_315.go file (they are commented in develop). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with a reservation;
there is a lot of duplicate code between sw_bls12377 and sw_bls24315, these should probably be... code generated, at least partially.
also, not sure this is the best sub package structure, don't want to mess with it too much while @ivokub PR (#181 ) is pending.
Will merge and create an issue to follow that.
[ready to merge]
issue #154
BW6-633 forms a 2-chain with BLS24-315. This PR adds support of BW6-633 in gnark and std (fields, SW arithmetic, pairing and recursive Groth16) of BLS24-315 in a BW6-633 circuit.