Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BW6-633 curve #185

Merged
merged 6 commits into from
Dec 1, 2021
Merged

Add BW6-633 curve #185

merged 6 commits into from
Dec 1, 2021

Conversation

yelhousni
Copy link
Contributor

@yelhousni yelhousni commented Nov 29, 2021

[ready to merge]

issue #154

BW6-633 forms a 2-chain with BLS24-315. This PR adds support of BW6-633 in gnark and std (fields, SW arithmetic, pairing and recursive Groth16) of BLS24-315 in a BW6-633 circuit.

@yelhousni yelhousni requested a review from gbotrel November 29, 2021 13:11
@gbotrel
Copy link
Collaborator

gbotrel commented Nov 30, 2021

@yelhousni ha, vet / build fails with:
"vet: std/algebra/fields_bls24315/e24.go:473:34: E24 not declared by package bls24315"
hence my other message :)

@yelhousni
Copy link
Contributor Author

@yelhousni ha, vet / build fails with: "vet: std/algebra/fields_bls24315/e24.go:473:34: E24 not declared by package bls24315" hence my other message :)

We just need to add E24 (and E8) types to bls24_315.go file (they are commented in develop).

@gbotrel gbotrel marked this pull request as draft November 30, 2021 19:54
@yelhousni yelhousni marked this pull request as ready for review December 1, 2021 15:35
Copy link
Collaborator

@gbotrel gbotrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a reservation;

there is a lot of duplicate code between sw_bls12377 and sw_bls24315, these should probably be... code generated, at least partially.

also, not sure this is the best sub package structure, don't want to mess with it too much while @ivokub PR (#181 ) is pending.

Will merge and create an issue to follow that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants