Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: restored sis #583

Merged
merged 6 commits into from
Dec 19, 2024
Merged

feat: restored sis #583

merged 6 commits into from
Dec 19, 2024

Conversation

ThomasPiellard
Copy link
Contributor

Description

Cleaned SIS code and templates, and added test cases for babybear, koalabear and goldilocks.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran or implemented to verify your changes. Provide instructions so we can reproduce.

See the test suite in the sis/ folders.

How has this been benchmarked?

Please describe the benchmarks that you ran to verify your changes.

See the benchmarks in the sis/ folders.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gbotrel gbotrel merged commit 97d69dc into master Dec 19, 2024
5 checks passed
@gbotrel gbotrel deleted the feat/gen_sis branch December 19, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants