Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Templates should handle correctly the cases where GLV and CofactorCleaning are set to false #60

Closed
yelhousni opened this issue Jun 8, 2021 · 1 comment
Closed

Templates should handle correctly the cases where GLV and CofactorCleaning are set to false #60

yelhousni opened this issue Jun 8, 2021 · 1 comment
Labels
cleanup Suggestion to clean up the code

Comments

@yelhousni
Copy link
Collaborator

e.g. In ./internal/generator/config/bls12-381.go, if we set GLV: false and CofactorCleaning: false, the template internal/generator/ecc/template/point.go.tmpl handles incorrectly this case.
@gbotrel gbotrel added the cleanup Suggestion to clean up the code label Dec 2, 2021
@yelhousni yelhousni mentioned this issue Dec 13, 2022
Merged
@yelhousni
Copy link
Collaborator Author

#281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Suggestion to clean up the code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gbotrel @yelhousni