Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement in-circuit ToTernary #269

Closed
yelhousni opened this issue Feb 24, 2022 · 2 comments · Fixed by #276
Closed

implement in-circuit ToTernary #269

yelhousni opened this issue Feb 24, 2022 · 2 comments · Fixed by #276
Assignees
@gbotrel
Labels
new feature

Comments

@yelhousni
Copy link
Contributor

Currently we have in-circuit binary decomposition api.ToBinary implemented with hints. It would be useful to have also a base-3 decomposition (or base-5 too).
@yelhousni
Copy link
Contributor Author

Also To2NAF might be interesting to try few things.

@gbotrel
Copy link
Collaborator

gbotrel commented Feb 24, 2022

Need some preliminary work ( #270 ) .
Maybe also a good occasion to move some bits operations in a std/bits or std/math/bits package to avoid surcharging the base API 👍

gbotrel added a commit that referenced this issue Mar 2, 2022
@gbotrel
feat: added ToTernary closes #269
5c556e1
@gbotrel gbotrel mentioned this issue Mar 8, 2022
Merged
@gbotrel gbotrel linked a pull request Mar 8, 2022 that will close this issue
Adds std/math/bits #276
Merged
@gbotrel gbotrel closed this as completed Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbotrel gbotrel

Labels
new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds std/math/bits Consensys/gnark
2 participants
@gbotrel @yelhousni