Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: recursive hints not supported by R1CS solver #293

Closed
3 tasks done
gbotrel opened this issue Mar 24, 2022 · 0 comments
Closed
3 tasks done

bug: recursive hints not supported by R1CS solver #293

gbotrel opened this issue Mar 24, 2022 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@gbotrel
Copy link
Collaborator

gbotrel commented Mar 24, 2022

if we consider h1 and h2, two hint functions.
h1 produces wire w1, h2 --> w2.

Now, if h2 takes as input w1, and w1 didn't appear in a constraint preceding the one solving w2, then the solver needs to solve h1 first when encountering h2, which is not currently the case.

  • add simple test case to reproduce the issue
  • restore panics in solver when a wire is unsolved (with debug tags only)
  • figure out how to deal with recursive hint solving (either when building dependencies in parallel levels, or at a later stage in the solver)
@gbotrel gbotrel added the bug Something isn't working label Mar 24, 2022
@gbotrel gbotrel added this to the v0.7.0 milestone Mar 24, 2022
@gbotrel gbotrel self-assigned this Mar 24, 2022
gbotrel added a commit that referenced this issue Mar 25, 2022
gbotrel added a commit that referenced this issue Mar 25, 2022
fix: closes #293 and enables recursive hints solving
@gbotrel gbotrel closed this as completed Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant