Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: direct MillerLoop in 2-chains precomputes G2 lines on copies #963

Open
ivokub opened this issue Dec 15, 2023 · 0 comments
Open

perf: direct MillerLoop in 2-chains precomputes G2 lines on copies #963

ivokub opened this issue Dec 15, 2023 · 0 comments

Comments

@ivokub
Copy link
Collaborator

ivokub commented Dec 15, 2023

Overflow issue from #949:

for two-chain we have wrapper for MillerLoop which goes from []G2Affine argument to []*G2Affine. But we compute the lines in the method which uses []G2Affine. However, as the slice contains of values then inside a method we are working on a copy of G2Affine value and we are not updating the lazy lines of the input. I think we can either change MillerLoop to take []*G2Affine so that can modify inline or precompute the lines in Pairing wrapper method Pairing.MillerLoop to already precompute. I like the first approach better because then we always will use lazy line computation.

But I guess better to resolve with #863

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant