Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: edge case with PLONK backend when 1 constraint #1226

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

ivokub
Copy link
Collaborator

@ivokub ivokub commented Jul 25, 2024

Description

Fixes big CI error. In Reduce test when emulating Goldilocks we only had a single constraint, but PLONK setup phase assumes circuit of size at least two.

The circuit size check is already defined in several issues: #864, #967. I also have locally open branch to add more helpful errors in case the circuit size is 0 or 1.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

CI

@ivokub ivokub added the bug Something isn't working label Jul 25, 2024
@ivokub ivokub requested a review from gbotrel July 25, 2024 15:34
@ivokub ivokub self-assigned this Jul 25, 2024
@ivokub ivokub requested a review from yelhousni July 25, 2024 15:36
@ivokub ivokub merged commit d6d85d4 into master Jul 25, 2024
7 checks passed
@ivokub ivokub deleted the fix/strict-modreduce-1limb branch July 25, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants