-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore frontend.WithCapacity (to merge after perf/debugInfo) #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ency of debug info
ivokub
approved these changes
Dec 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think it would be possible to tweak the 0.1 multiplier for number of boolean linear expressions and coefficients, but this is quite circuit-specific.
ivokub
added a commit
that referenced
this pull request
Feb 17, 2023
commit 82eeb20 Author: Gautam Botrel <gautam.botrel@gmail.com> Date: Thu Dec 22 13:13:01 2022 -0600 fix: don't overwrite buffer when compressing le commit 6fc0594 Author: Gautam Botrel <gautam.botrel@gmail.com> Date: Thu Dec 22 13:10:07 2022 -0600 revert: revert builder.linearExpression method commit e7711d3 Author: Gautam Botrel <gautam.botrel@gmail.com> Date: Thu Dec 22 13:03:03 2022 -0600 style: clean PR from NewBuffer commit 00361d8 Merge: af31f2e 66e4fab Author: Gautam Botrel <gautam.botrel@gmail.com> Date: Thu Dec 22 12:51:29 2022 -0600 Merge remote-tracking branch 'origin/develop' into feat/apiMAC commit af31f2e Author: Gautam Botrel <gautam.botrel@gmail.com> Date: Thu Dec 22 12:51:13 2022 -0600 feat: add api.MAC and api.Compiler().NewBuffer(capacity) commit 66e4fab Author: Gautam Botrel <gautam.botrel@gmail.com> Date: Thu Dec 22 12:40:02 2022 -0600 Restore frontend.WithCapacity (to merge after perf/debugInfo) (#423) * feat: add debug.SymbolTable into constraint system for storage efficiency of debug info * feat: solution takes symbol table only, limit stack size to 2 without debug * perf: don't store stack for assert boolean if no debug flag * perf: restore frontend.WithCapacity usage * fix: fix line number in Example output * fix: remove boolean trace test commit 4718886 Merge: 2a0ef4c 24fe00b Author: Gautam Botrel <gautam.botrel@gmail.com> Date: Wed Dec 21 09:15:45 2022 -0600 Merge branch 'develop' into feat/apiMAC commit 24fe00b Author: Gautam Botrel <gautam.botrel@gmail.com> Date: Wed Dec 21 09:09:41 2022 -0600 feat: add debug.SymbolTable into constraint system for storage efficiency of debug info (#421) * feat: add debug.SymbolTable into constraint system for storage efficiency of debug info * feat: solution takes symbol table only, limit stack size to 2 without debug * perf: don't store stack for assert boolean if no debug flag * fix: fix line number in Example output * fix: remove boolean trace test commit 2a0ef4c Author: Gautam Botrel <gautam.botrel@gmail.com> Date: Tue Dec 20 17:58:06 2022 -0600 experiment checkpoint commit b3778b3 Author: Gautam Botrel <gautam.botrel@gmail.com> Date: Tue Dec 20 15:59:10 2022 -0600 autogenerate tinyfield arithmetic (#424) * feat: auto generate tiny field * fix: update toBigInt interface for conversion element - big int * fix: revert previous commit commit 739a2d9 Merge: 35dccd5 2128e51 Author: Gautam Botrel <gautam.botrel@gmail.com> Date: Tue Dec 20 15:17:04 2022 -0600 Merge branch 'perf/debuginfo' into perf/capacity commit 2128e51 Author: Gautam Botrel <gautam.botrel@gmail.com> Date: Tue Dec 20 15:16:53 2022 -0600 fix: remove boolean trace test commit 19312ea Merge: 1ab5fff 908eb80 Author: Gautam Botrel <gautam.botrel@gmail.com> Date: Tue Dec 20 15:15:04 2022 -0600 Merge branch 'develop' into perf/debuginfo commit 908eb80 Author: Arya Tabaie <arya.pourtabatabaie@gmail.com> Date: Tue Dec 20 15:14:35 2022 -0600 Reflect PRs in gnark-crypto: A field element is always in Montgomery form and big.Ints are always non-Mont (#422) * refactor: no non-mont on bls12-377 * refactor: groth16 backend tests pass * refactor: MSM takes Montgomery only - Plonk * fix:`ToBigIntRegular` => `BigInt` * fix: more `ToBigIntRegular` => `BigInt` commit 35dccd5 Merge: 480df50 1ab5fff Author: Gautam Botrel <gautam.botrel@gmail.com> Date: Tue Dec 20 14:59:04 2022 -0600 Merge branch 'perf/debuginfo' into perf/capacity commit 1ab5fff Author: Gautam Botrel <gautam.botrel@gmail.com> Date: Tue Dec 20 14:58:53 2022 -0600 fix: fix line number in Example output commit 480df50 Author: Gautam Botrel <gautam.botrel@gmail.com> Date: Tue Dec 20 14:58:21 2022 -0600 perf: restore frontend.WithCapacity usage commit f918071 Author: Gautam Botrel <gautam.botrel@gmail.com> Date: Tue Dec 20 14:44:20 2022 -0600 perf: don't store stack for assert boolean if no debug flag commit 1204a89 Author: Gautam Botrel <gautam.botrel@gmail.com> Date: Tue Dec 20 14:40:40 2022 -0600 feat: solution takes symbol table only, limit stack size to 2 without debug commit 2c0390a Author: Gautam Botrel <gautam.botrel@gmail.com> Date: Tue Dec 20 14:10:58 2022 -0600 feat: add debug.SymbolTable into constraint system for storage efficiency of debug info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.