Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor, perf: 2-chains pairing + groth16 API #664

Merged
merged 7 commits into from
May 15, 2023

Conversation

yelhousni
Copy link
Contributor

  • fixes Refactor 2-Chain std API #607 (for both bls12 and bls24 2-chains)
  • consolidate pairing code with emulated package
  • perf: saves 15 constraints for bls12/bw6 Groth16 and 63 for bls24/bw6

@yelhousni yelhousni added consolidate strengthen an existing feature perf labels Apr 26, 2023
@yelhousni yelhousni added this to the v0.9.0 milestone Apr 26, 2023
@yelhousni yelhousni requested a review from gbotrel April 26, 2023 17:18
@yelhousni yelhousni self-assigned this Apr 26, 2023
Copy link
Collaborator

@gbotrel gbotrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍 modulo, probably changing FillG1K method name with something clearer and documented (like Allocate() maybe?)

std/groth16_bls12377/verifier.go Outdated Show resolved Hide resolved
@gbotrel gbotrel merged commit 7d3c0f5 into develop May 15, 2023
@gbotrel gbotrel deleted the perf/2-chains-pairing branch May 15, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consolidate strengthen an existing feature perf
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants