feat: improve tx-exclusion-api performance and increase size of reaso… #327
+40
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonesho
temporarily deployed
to
docker-build-and-e2e
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #327 +/- ##
============================================
- Coverage 70.32% 70.28% -0.04%
Complexity 1081 1081
============================================
Files 304 304
Lines 12413 12413
Branches 1179 1179
============================================
- Hits 8729 8725 -4
- Misses 3190 3193 +3
- Partials 494 495 +1
*This pull request uses carry forward flags. Click here to find out more.
|
jonesho
force-pushed
the
4019-improvement-on-tx-exclusion-api
branch
from
b436242
to
fee2c5b
Compare
jonesho
commented
Nov 22, 2024
...n/net/consensys/zkevm/persistence/dao/rejectedtransaction/RejectedTransactionsPostgresDao.kt
Show resolved
Hide resolved
.../src/testFixtures/kotlin/net/consensys/zkevm/persistence/db/test/CleanDbTestSuiteParallel.kt
Outdated
Show resolved
Hide resolved
.../src/main/resources/db/V003__increase_reject_reason_size_and_add_index_on_tx_hash_schema.sql
Show resolved
Hide resolved
.../src/main/resources/db/V003__increase_reject_reason_size_and_add_index_on_tx_hash_schema.sql
Show resolved
Hide resolved
jonesho
temporarily deployed
to
docker-build-and-e2e
GitHub Actions
Inactive
|
Related issue: https://github.com/Consensys/zkevm-monorepo/issues/4019 |
jpnovais
previously approved these changes
Nov 22, 2024
jonesho
temporarily deployed
to
docker-build-and-e2e
GitHub Actions
Inactive
…date prover-v3 image tag in compose
jonesho
temporarily deployed
to
docker-build-and-e2e
GitHub Actions
Inactive
jonesho
commented
Nov 23, 2024
| @@ -162,7 +162,7 @@ dockerCompose { | |||
| ] | |||
| useComposeFiles = ["${project.rootDir.path}/docker/compose.yml"] | |||
| waitForHealthyStateTimeout = Duration.ofMinutes(3) | |||
| waitForTcpPorts = false | |||
| waitForTcpPorts = true | |||
There was a problem hiding this comment.
Setting this to true should avoid race condition issue when postgres container starts up and immediately followed by tx-exclusion-api integration test, given the healthy state check might not be good enough to ensure that the postgres container is ready to accept connection, especially when the tx-exclusion-api integration test only requires postgres container alone.
jonesho
commented
Nov 23, 2024
| @@ -68,7 +68,7 @@ services: | |||
| prover-v3: # prover compatible with the traces from zkbesu | |||
| container_name: prover-v3 | |||
| hostname: prover-v3 | |||
| image: consensys/linea-prover:${PROVER_TAG:-bba9677} | |||
| image: consensys/linea-prover:${PROVER_TAG:-8544ea1} | |||
There was a problem hiding this comment.
update the image tag of prover-v3 to cope with the recent change of prover config
jonesho
commented
Nov 23, 2024
| @@ -26,8 +26,6 @@ abstract class CleanDbTestSuiteParallel { | |||
|
|
|||
| private fun createDataSource(databaseName: String): DataSource { | |||
| return PGSimpleDataSource().also { | |||
| it.ssl = false | |||
| it.gssEncMode = "disable" | |||
| it.serverNames = arrayOf(host) | |||
There was a problem hiding this comment.
Reverted the above changes as it didn't fix the tx-exclusion-api integration test random failure issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n message column
This PR implements issue(s) #
Checklist