Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go 1.13 on macOS gives file descriptor problem #889

Closed
jeffallen opened this issue Nov 22, 2019 · 2 comments · Fixed by #892
Closed

go 1.13 on macOS gives file descriptor problem #889

jeffallen opened this issue Nov 22, 2019 · 2 comments · Fixed by #892

Comments

@jeffallen
Copy link

I understand (from Slack history, thread from Sep 7) that for the moment only Go 1.11.x is supported. This is not clearly documented, and really difficult to figure out if you naively try to follow the getting started docs (i.e. https://github.com/jpmorganchase/quorum-examples#running-locally)

On MacOS, the failing behaviour of Go 1.13 is: Fatal: Failed to raise file descriptor allowance: invalid argument which is very difficult to connect to the need to downgrade Go. (See also #756.)

I think it would be helpful to:

  • document the Go 1.11.x limitation better
  • enforce the Go 1.11.x limitation in build/env.sh, so that if you try building with go 1.13, you get a nice loud error
  • use something like the code in dedis/onet@03a8c57#diff-f7b6c3a5b64e312c20712b3c2ae51345 in order to make file descriptor setting work in MacOS again

I don't know if upstream has already solved this, or if I should be reporting it there.

@prd-fox
Copy link
Contributor

prd-fox commented Nov 22, 2019

Hi!

I'll add a note to the documentation stating this.

This was solved upstream in version 1.9.0.
Here is the relevant file:
https://github.com/ethereum/go-ethereum/blob/master/common/fdlimit/fdlimit_darwin.go

Once we have updated to 1.9.0 or later, I will remove the note about supported Go versions.

@magus777
Copy link

magus777 commented Jul 6, 2022

Issue still happening for me on:

go version go1.18.3 darwin/amd64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants