-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update /validator/block API description. #1664
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net>
rolfyone
reviewed
Apr 26, 2020
...onrestapi/src/main/java/tech/pegasys/artemis/beaconrestapi/handlers/validator/PostBlock.java
Outdated
Show resolved
Hide resolved
rolfyone
approved these changes
Apr 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit.
Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net>
NicolasMassart
added a commit
to NicolasMassart/teku
that referenced
this pull request
Apr 27, 2020
commit 1cc3466 Author: Sally MacFarlane <sally.macfarlane@consensys.net> Date: Mon Apr 27 15:44:58 2020 +1000 added subcommand in message (Consensys#1671) Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> commit af1c82a Author: bgravenorst <50852695+bgravenorst@users.noreply.github.com> Date: Mon Apr 27 11:38:15 2020 +1000 Update /validator/block API description. (Consensys#1664) * Update API description. Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net> * Address feedback. Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net> commit 6936481 Author: Paul Harris <paul.harris@consensys.net> Date: Mon Apr 27 10:35:52 2020 +1000 network cli test cases (Consensys#1667) * added a test case to show network option taking a URL. * split out some other command line options tests into their own modules, and added config file parsing. Signed-off-by: Paul Harris <paul.harris@consensys.net> commit f79f65f Author: Adrian Sutton <adrian.sutton@consensys.net> Date: Mon Apr 27 07:15:18 2020 +1000 Implement attestation gossip validation requirements (Consensys#1661) commit 56a3b87 Author: Raw Pong Ghmoa <58883403+q9f@users.noreply.github.com> Date: Sun Apr 26 22:53:11 2020 +0200 cli/deposit: significantly simplify validator keystore path (Consensys#1618) commit 381b9b5 Author: Anton Nashatyrev <Nashatyrev@users.noreply.github.com> Date: Sat Apr 25 21:12:08 2020 +0300 Optimize: batch BLS verification (Consensys#1632) * Add batch BLS verification * Parallelize batch BLS commit 340af2c Author: Cem Ozer <cemozer2018@u.northwestern.edu> Date: Fri Apr 24 12:50:10 2020 -0400 Remove headBockRoot from beaconBlocksByRange request (Consensys#1659)
NicolasMassart
added a commit
to NicolasMassart/teku
that referenced
this pull request
Apr 27, 2020
commit 1cc3466 Author: Sally MacFarlane <sally.macfarlane@consensys.net> Date: Mon Apr 27 15:44:58 2020 +1000 added subcommand in message (Consensys#1671) Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> commit af1c82a Author: bgravenorst <50852695+bgravenorst@users.noreply.github.com> Date: Mon Apr 27 11:38:15 2020 +1000 Update /validator/block API description. (Consensys#1664) * Update API description. Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net> * Address feedback. Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net> commit 6936481 Author: Paul Harris <paul.harris@consensys.net> Date: Mon Apr 27 10:35:52 2020 +1000 network cli test cases (Consensys#1667) * added a test case to show network option taking a URL. * split out some other command line options tests into their own modules, and added config file parsing. Signed-off-by: Paul Harris <paul.harris@consensys.net> commit f79f65f Author: Adrian Sutton <adrian.sutton@consensys.net> Date: Mon Apr 27 07:15:18 2020 +1000 Implement attestation gossip validation requirements (Consensys#1661) commit 56a3b87 Author: Raw Pong Ghmoa <58883403+q9f@users.noreply.github.com> Date: Sun Apr 26 22:53:11 2020 +0200 cli/deposit: significantly simplify validator keystore path (Consensys#1618) commit 381b9b5 Author: Anton Nashatyrev <Nashatyrev@users.noreply.github.com> Date: Sat Apr 25 21:12:08 2020 +0300 Optimize: batch BLS verification (Consensys#1632) * Add batch BLS verification * Parallelize batch BLS commit 340af2c Author: Cem Ozer <cemozer2018@u.northwestern.edu> Date: Fri Apr 24 12:50:10 2020 -0400 Remove headBockRoot from beaconBlocksByRange request (Consensys#1659)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Byron Gravenorst byron.gravenorst@consensys.net
PR Description
Updated
/validator/block
description