[MEV Boost\Builder] Support for validator registration in VC #5598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolfyone
reviewed
May 26, 2022
Comment on lines
130
to
118
| inOrder.verify(validatorApiChannel, timeout(5000)).registerValidators(argumentCaptor.capture()); | ||
| verifyRegistrations(argumentCaptor.getValue()); |
There was a problem hiding this comment.
5 seconds in a unit test is a long time...
There was a problem hiding this comment.
thanks, will keep in mind, changed to 1 second
rolfyone
reviewed
May 26, 2022
| verifyRegistrations(argumentCaptor.getValue()); | ||
|
|
||
| // WHEN onSlot called again next time in a beginning of an epoch, registrations will be cached | ||
| validatorRegistrator.onSlot(UInt64.ZERO); |
There was a problem hiding this comment.
can we call this onSlot with a different value? my hope is we never would call it with zero more than once...
There was a problem hiding this comment.
good point, changed it to the slot at the beginning of next epoch
StefanBratanov
force-pushed
the
validator_registration_vc
branch
from
9df3b21 to
b89b355
Compare
StefanBratanov
changed the title
StefanBratanov
force-pushed
the
validator_registration_vc
branch
from
b89b355 to
e3b474d
Compare
StefanBratanov
force-pushed
the
validator_registration_vc
branch
from
339db0d to
051746d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Adding
ValidatorRegistratorwhich will send validator registrations to the Beacon Node on beginning of epoch, on startup and when new validators are added.Fixed Issue(s)
fixes #5596
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog