Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Use More Up-to-date Version of AllenNLP? #102

Open
VanillaCappuccino opened this issue Dec 12, 2022 · 1 comment
Open

Suggestion: Use More Up-to-date Version of AllenNLP? #102

VanillaCappuccino opened this issue Dec 12, 2022 · 1 comment

Comments

@VanillaCappuccino
Copy link

Hello,

I've tried running the tutorials and bumped into a wall, though this is not as major an issue as I was worried about.

allennlp.data.tokenizers.word_splitter is only used in MILU, but for those on more up-to-date versions of AllenNLP (like myself, who just pip installed it to run the tutorial notebook) will be stopped here as WordSplitter appears to have been replaced by a more general tokeniser after the 1.0.0 release: allenai/allennlp#3345.

A solution is to obviously only use the relevant libraries (which I could have avoided from the get-go, as I will only be playing around with generation libraries). I appreciate that you might have your very own reasons for using an older version, but updating this and any other similar use cases (or at least a disclaimer) would be a great time-saver for beginner-level people like myself who are just looking to get started with this.

image

@zqwerty
Copy link
Member

zqwerty commented Dec 19, 2022

Thanks for the suggestion! The code of MILU is a little bit old and relies heavily on allennlp==0.9, so it will need some effort to update the allennlp. Do you have the interest to contribute?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants