Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sapdecompress.h:62:1: error: narrowing conversion of ‘-1’ from ‘int’ to ‘guint32 {aka unsigned int}’ #10

Closed
joergsch opened this issue Nov 17, 2016 · 2 comments
Closed

sapdecompress.h:62:1: error: narrowing conversion of ‘-1’ from ‘int’ to ‘guint32 {aka unsigned int}’ #10

joergsch opened this issue Nov 17, 2016 · 2 comments
Assignees
@martingalloar

Comments

@joergsch
Copy link

Compiling the plugin (from branch wirehsark-2.2) on my Linux system resulted in a few errors:
sapdecompress.h:62:1: error: narrowing conversion of '-1' from 'int' to 'guint32 {aka unsigned int}'

By replacing -1 with 0xffffffff - 1 (same adjustment with the following lines) the code could be compiled.
martingalloar pushed a commit that referenced this issue Nov 17, 2016
Removed use of value_string for decompression return code (#10)
778a49c 
As return errors can be negative on an error, we can't use value_string for that. Moved into a plain field with custom formatting.
@martingalloar
Copy link
Contributor

Thanks for reporting the issue! Indeed that was a warning that was since long time ago, but apparently your compiler flags were set to considered it an error. Anyway, check with the updated code to see if it's working now, I've replaced the entire use of value_string for decompression error codes, so those ugly conversions shouldn't be there anymore.

@martingalloar martingalloar self-assigned this Nov 17, 2016
@joergsch
Copy link
Author

It compiles without any error. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martingalloar martingalloar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@martingalloar @joergsch