Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor multilib::wasm::WasmKeeper tests to use mulitest::wasm::Wasm instead of internal functions #3

Closed
hashedone opened this issue Jul 29, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@hashedone
Copy link
Contributor

hashedone commented Jul 29, 2021

Some multi-lib entities are unit tested on their internal levels, instead of their actual exposed API, which could be improved to capture additional orchestration logic, and avoid depending on internals stability.

It is follow up of CosmWasm/cw-plus#360

@ethanfrey
Copy link
Member

I think we can depend on WamsKeeper, as we have generic in App/Router and do call them sometimes.

I do agree we can avoid calling private methods and try only pub ones. Any way to get the compiler to enforce that?

@ethanfrey
Copy link
Member

Also find this as not urgent... but a nice cleanup

@uint uint transferred this issue from CosmWasm/cw-plus Oct 17, 2022
@hashedone
Copy link
Contributor Author

Closed - over 2 years refactoring task, even if still reasonable it should be reconsidered from scratch

@DariuszDepta DariuszDepta self-assigned this Mar 8, 2024
Kayanski referenced this issue in AbstractSDK/cw-multi-test-fork Jun 27, 2024
* Integrated rust contracts

* Some clippy fixes ?

* Less unsafe code

* Fixed with features

* Added dual storage for cosmwas-std

* Added dual storage for wrappers as well

* Added storage and querier inside rust code contracts

* Modified storage accessor to just wrap

* Fixed contract address when querying contract

* Fixed raw query return

* Updated deps

* Corrected querier storage after funds transfer on execute

* Removed prints

* Fixed minor print error

* Updated api in wasm-emulation querier

* Fix clippy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants