Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import export simulation test for x/wasm is missing #1372

Closed
dadamu opened this issue May 2, 2023 · 1 comment · Fixed by #1374
Closed

import export simulation test for x/wasm is missing #1372

dadamu opened this issue May 2, 2023 · 1 comment · Fixed by #1374

Comments

@dadamu
Copy link
Contributor

dadamu commented May 2, 2023

Currently, x/wasm is not added to store prefix list should be checked inside TestAppImportExport. Is any reasons not to add the check for x/wasm?
https://github.com/CosmWasm/wasmd/blob/main/app/sim_test.go#L158

By the way, the simulation test happens error as follows since the random genesis state does not generate proper LastInstanceID.
https://github.com/CosmWasm/wasmd/blob/main/x/wasm/simulation/genesis.go#L17

The error would be like:

compared 2 different key/value pairs between KVStoreKey{0xc001218320, wasm} and KVStoreKey{0xc000302450, wasm}
    sim_test.go:275: 
                Error Trace:    /home/kilem/forbole-dev/desmos/app/sim_test.go:275
                Error:          Not equal: 
                                expected: 2
                                actual  : 0
                Test:           TestAppImportExport
                Messages:       store A  => 
                            
                                store B lastContractId => 
                                store A  => 
                                store B  =>

May I take care of this issue if the thing I proposed is worth to you?

@alpe
Copy link
Contributor

alpe commented May 3, 2023

Thanks for reporting! Good 👁️ .
There is no reason to exclude the wasm module from the test. The CircleCI sim run should have caught this but did not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants