Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept wasm data from state-sync as valid #1467

Closed
alpe opened this issue Jun 28, 2023 · 2 comments · Fixed by #1471
Closed

Accept wasm data from state-sync as valid #1467

alpe opened this issue Jun 28, 2023 · 2 comments · Fixed by #1471
Assignees
@pinosu
Milestone
v0.41.0

Comments

@alpe
Copy link
Contributor

alpe commented Jun 28, 2023

The max code size limit must not prevent a legacy contract to be stored when it was accepted before:
Follow up on https://twitter.com/pwnfoo/status/1674052643214307329
@webmaster128
Copy link
Member

Also from CosmWasm 1.3 onwards there will be VM.StoreCode and Vm.StoreCodeUnchecked (new names for the deprecated VM.Create) in order to avoid the same problem for checks in the CosmWasm static validation.

@alpe alpe added this to the v0.41.0 milestone Jun 28, 2023
@pwnfoo
Copy link

pwnfoo commented Jun 28, 2023

Thank you for the fast response. Let me know if you need any additional info!

@pinosu pinosu self-assigned this Jun 29, 2023
@pinosu pinosu mentioned this issue Jun 29, 2023
Merged
@akc2267 akc2267 mentioned this issue Sep 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pinosu pinosu

Labels
None yet
Projects
None yet
Milestone
v0.41.0
Development

Successfully merging a pull request may close this issue.

Remove check for wasm limit size in state sync CosmWasm/wasmd
4 participants
@alpe @webmaster128 @pwnfoo @pinosu