Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build docker image without Ledger support #225

Closed
webmaster128 opened this issue Jul 27, 2020 · 1 comment
Closed

Build docker image without Ledger support #225

webmaster128 opened this issue Jul 27, 2020 · 1 comment

Comments

@webmaster128
Copy link
Member

In the Dockerfile we have this block twice:

# without this, build with LEDGER_ENABLED=false
RUN apk add libusb-dev linux-headers

and get some annoying build warnings like

go: downloading github.com/btcsuite/btcutil v1.0.2
go: downloading github.com/spf13/pflag v1.0.5
go: downloading github.com/gorilla/websocket v1.4.2
go: downloading github.com/zondax/hid v0.9.0
# github.com/zondax/hid
In file included from /go/pkg/mod/github.com/zondax/hid@v0.9.0/hid_enabled.go:22:
/usr/include/sys/poll.h:1:2: warning: #warning redirecting incorrect #include <sys/poll.h> to <poll.h> [-Wcpp]
    1 | #warning redirecting incorrect #include <sys/poll.h> to <poll.h>
      |  ^~~~~~~
go build -mod=readonly -tags netgo,ledger,muslc -ldflags '-X github.com/cosmos/cosmos-sdk/version.Name=wasm -X github.com/cosmos/cosmos-sdk/version.ServerName=wasmd -X github.com/cosmos/cosmos-sdk/version.ClientName=wasmcli -X github.com/cosmos/cosmos-sdk/version.Version=0.10.0-alpha-13-gebd9b29 -X github.com/cosmos/cosmos-sdk/version.Commit=ebd9b29ef7b51dd4cc89f09ff09ec403b09dbfa8 -X "github.com/cosmos/cosmos-sdk/version.BuildTags=netgo,ledger,muslc"' -trimpath -o build/wasmgovd ./cmd/wasmgovd
# github.com/zondax/hid
In file included from /go/pkg/mod/github.com/zondax/hid@v0.9.0/hid_enabled.go:22:
/usr/include/sys/poll.h:1:2: warning: #warning redirecting incorrect #include <sys/poll.h> to <poll.h> [-Wcpp]
    1 | #warning redirecting incorrect #include <sys/poll.h> to <poll.h>
      |  ^~~~~~~
go build -mod=readonly -tags netgo,ledger,muslc -ldflags '-X github.com/cosmos/cosmos-sdk/version.Name=wasm -X github.com/cosmos/cosmos-sdk/version.ServerName=wasmd -X github.com/cosmos/cosmos-sdk/version.ClientName=wasmcli -X github.com/cosmos/cosmos-sdk/version.Version=0.10.0-alpha-13-gebd9b29 -X github.com/cosmos/cosmos-sdk/version.Commit=ebd9b29ef7b51dd4cc89f09ff09ec403b09dbfa8 -X "github.com/cosmos/cosmos-sdk/version.BuildTags=netgo,ledger,muslc"' -trimpath -o build/wasmcli ./cmd/wasmcli
go: downloading github.com/rakyll/statik v0.1.6
go: downloading github.com/gorilla/handlers v1.4.2
# github.com/zondax/hid
In file included from /go/pkg/mod/github.com/zondax/hid@v0.9.0/hid_enabled.go:22:
/usr/include/sys/poll.h:1:2: warning: #warning redirecting incorrect #include <sys/poll.h> to <poll.h> [-Wcpp]
    1 | #warning redirecting incorrect #include <sys/poll.h> to <poll.h>
      |  ^~~~~~~

I wonder if we need ledger support at all in the default docker file. I assume CLI+Ledger users would compile their cli tools natively on the dev machine.

@ethanfrey
Copy link
Member

Closed by #227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants