Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendor protobuf definitions for proto-lint/ proto-check-breaking #243

Closed
alpe opened this issue Aug 4, 2020 · 1 comment
Closed

Vendor protobuf definitions for proto-lint/ proto-check-breaking #243

alpe opened this issue Aug 4, 2020 · 1 comment
Labels
wontfix This will not be worked on

Comments

@alpe
Copy link
Contributor

alpe commented Aug 4, 2020

We depend on:

  • go list -f "{{ .Dir }}" -m github.com/cosmos/cosmos-sdk)/third_party/proto
  • go list -f "{{ .Dir }}" -m github.com/cosmos/cosmos-sdk)/proto

and point to them from our ./scripts/protocgen.sh file.
The proto lint and check breaking tasks in our makefile depend on a fix path though that is configured in buf.yaml.

We should consider vendoring the proto files or cleanup the makefile.
@ethanfrey ethanfrey added this to the v2.0.0 milestone Aug 19, 2020
@alpe alpe modified the milestones: v2.0.0, v1.0.0 Oct 14, 2020
@alpe alpe mentioned this issue Oct 29, 2020
Closed
@alpe
Copy link
Contributor Author

alpe commented Nov 10, 2020

I am doing some docker mounts in #304 to enable the linter. This issue becomes obsolete by this

@alpe alpe closed this as completed Nov 10, 2020
@alpe alpe added the wontfix This will not be worked on label Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alpe @ethanfrey