Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extendable gas costs #525

Closed
alpe opened this issue May 28, 2021 · 1 comment · Fixed by #533
Closed

Extendable gas costs #525

alpe opened this issue May 28, 2021 · 1 comment · Fixed by #533
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@alpe
Copy link
Contributor

alpe commented May 28, 2021

Gas costs are currently constants in the Code that can not be changed without forking. For example https://github.com/CosmWasm/wasmd/blob/master/x/wasm/keeper/keeper.go#L41

We should not enforce the same costs on every chain that is using this module. Some options are

  • Params (create extra gas costs)
  • Overwrite via compile time flag on a var
  • Abstract provider interface that returns the value
@alpe alpe added the enhancement New feature or request label May 28, 2021
@alpe alpe added this to the v1.0.0 milestone May 28, 2021
@ethanfrey
Copy link
Member

Important to allow this customization.

Overwrite via compile time flag on a var

I would support this as an easy first step. You could override when compiling wasmd, or in the app.go of any chain importing x/wasm. These need to be able to be tuned, but I do not think very often.

Params (create extra gas costs)

This is an important one for any gas costs or limits that need to be adjusted "quickly" with a governance vote without redeploying a new binary. I would reflect carefully on what fields to add to params if it would really be useful (and just use public var for the rest)

@alpe alpe modified the milestones: v1.0.0, v0.18.0 Jun 11, 2021
@alpe alpe self-assigned this Jun 11, 2021
@alpe alpe closed this as completed in #533 Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants