Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize BalanceQuery in query plugin #606

Closed
alpe opened this issue Sep 13, 2021 · 1 comment · Fixed by #609
Closed

Optimize BalanceQuery in query plugin #606

alpe opened this issue Sep 13, 2021 · 1 comment · Fixed by #609
Milestone

Comments

@alpe
Copy link
Contributor

alpe commented Sep 13, 2021

We can use GetBalance now instead of iterating through the list

@alpe alpe added this to the v0.20.0 milestone Sep 13, 2021
@ethanfrey
Copy link
Member

Very good point and much more efficient. This is why there were two different queries in the first place.

I was surprised to find https://github.com/CosmWasm/wasmd/blob/master/x/wasm/keeper/query_plugins.go#L171-L178 wasn't updated after the Stargate upgrade. But so many things to do there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants