Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cosmwasm project prefix to REST query paths #743

Merged
merged 7 commits into from
Feb 8, 2022

Conversation

pinosu
Copy link
Contributor

@pinosu pinosu commented Feb 3, 2022

Resolves #690

dependabot bot and others added 2 commits January 31, 2022 08:13
Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.12.0 to 1.12.1.
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md)
- [Commits](prometheus/client_golang@v1.12.0...v1.12.1)

---
updated-dependencies:
- dependency-name: github.com/prometheus/client_golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@pinosu pinosu requested a review from alpe as a code owner February 3, 2022 16:44
Bumps [github.com/cosmos/ibc-go/v2](https://github.com/cosmos/ibc-go) from 2.0.2 to 2.0.3.
- [Release notes](https://github.com/cosmos/ibc-go/releases)
- [Changelog](https://github.com/cosmos/ibc-go/blob/v2.0.3/CHANGELOG.md)
- [Commits](cosmos/ibc-go@v2.0.2...v2.0.3)

---
updated-dependencies:
- dependency-name: github.com/cosmos/ibc-go/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@pinosu
Copy link
Contributor Author

pinosu commented Feb 4, 2022

@ethanfrey @maurolacy

Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.
There are some formatting issues with the imports though. Otherwise it looks very good 💐
Can you run make format please?
I usually run make proto-all for protobuf file generation, which includes the formatting step.

alpe and others added 4 commits February 7, 2022 08:56
…ithub.com/cosmos/ibc-go/v2-2.0.3

Bump github.com/cosmos/ibc-go/v2 from 2.0.2 to 2.0.3
…ithub.com/prometheus/client_golang-1.12.1

Bump github.com/prometheus/client_golang from 1.12.0 to 1.12.1
@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #743 (6f28a82) into master (7625caf) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #743      +/-   ##
==========================================
- Coverage   58.51%   58.47%   -0.04%     
==========================================
  Files          49       49              
  Lines        5828     5828              
==========================================
- Hits         3410     3408       -2     
- Misses       2169     2170       +1     
- Partials      249      250       +1     
Impacted Files Coverage Δ
x/wasm/keeper/keeper.go 87.54% <0.00%> (-0.36%) ⬇️

@alpe alpe merged commit 0715380 into CosmWasm:master Feb 8, 2022
@alpe
Copy link
Contributor

alpe commented Feb 8, 2022

Thanks for the changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REST query path should contain cosmwasm project prefix
2 participants