Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not Able to Instantiate the Contract using governance if admin is not provided #768

Closed
cryptoVrse opened this issue Mar 1, 2022 · 2 comments · Fixed by #771
Closed

Not Able to Instantiate the Contract using governance if admin is not provided #768

cryptoVrse opened this issue Mar 1, 2022 · 2 comments · Fixed by #771
Labels
bug Something isn't working

Comments

@cryptoVrse
Copy link

no-admin flag is not added while using governance to instantiate the contract.

@ethanfrey
Copy link
Member

If you do it without --no-admin it passes, right?

I believe the issue is we did not add the enforcement of either --admin XYZ or --no-admin like the normal instantiate and treat a missing --admin flag as no admin. Can you verify the current behavior and the desired behavior? Ideally pasting the cli commands you are using,

@cryptoVrse
Copy link
Author

It didn't passes if we don't provide the --no-admin flag and gave the below error -

comdex tx gov submit-proposal instantiate-contract 1 '{"name":"GOOGLE","symbol":"mGOO","decimals":6,"initial_balances":[],"mint":{"cap":null,"minter":"comdex13wp8k2deecj0v38wplk4zc6g533kxw0a9mx940"}}' --label "mint" --title "inst" --description "cont" --run-as $(comdex keys show admin -a)
Enter keyring passphrase:
Error: no-admin: flag accessed but not defined: no-admin

comdex keys show admin -a here admin is my key name(Please don't get confuse).

If we provide the --no-admin flag, it gives the below error -

comdex tx gov submit-proposal instantiate-contract 1 '{"name":"GOOGLE","symbol":"mGOO","decimals":6,"initial_balances":[],"mint":{"cap":null,"minter":"comdex13wp8k2deecj0v38wplk4zc6g533kxw0a9mx940"}}' --label "mint" --title "inst" --description "cont" --run-as $(comdex keys show admin -a) --no-admin
Enter keyring passphrase:
Error: unknown flag: --no-admin

if we provide the --admin flag, still it gives the below error -

comdex tx gov submit-proposal instantiate-contract 1 '{"name":"GOOGLE","symbol":"mGOO","decimals":6,"initial_balances":[],"mint":{"cap":null,"minter":"comdex13wp8k2deecj0v38wplk4zc6g533kxw0a9mx940"}}' --label "mint" --title "inst" --description "cont" --run-as $(comdex keys show admin -a) --admin comdex13wp8k2deecj0v38wplk4zc6g533kxw0a9mx940
Enter keyring passphrase:
Error: no-admin: flag accessed but not defined: no-admin

@alpe alpe added the bug Something isn't working label Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants