Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove genesis messages #987

Closed
2 tasks
alpe opened this issue Sep 7, 2022 · 2 comments · Fixed by #1104
Closed
2 tasks

Remove genesis messages #987

alpe opened this issue Sep 7, 2022 · 2 comments · Fixed by #1104
Assignees
@pinosu
Milestone
v0.31.0

Comments

@alpe
Copy link
Contributor

alpe commented Sep 7, 2022 •
edited
Loading

Genesis messages are a complex functionality in the code and not easy to main.
Not sure if it is used by anybody.

  • Remove from CLI
  • Remove from genesis protobuf
@ethanfrey
Copy link
Member

I would agree with this and only use wasmd genesis to load existing contracts and state (from a state dump) rather than add new contracts. But maybe there are some use cases that need this 🤷

If we do keep it, I think this needs more testing (also manual testing in production by others)

@alpe
Copy link
Contributor Author

alpe commented Sep 9, 2022

I used them for system tests in tgrade only

This was referenced Sep 14, 2022
Merged
Merged
@alpe alpe moved this to 🆕 New in wasmd backlog Sep 23, 2022
@alpe alpe moved this from 🆕 New to 📋 Unsorted Backlog in wasmd backlog Sep 23, 2022
@ethanfrey ethanfrey added this to the v0.31.0 milestone Nov 4, 2022
@pinosu pinosu self-assigned this Nov 22, 2022
@pinosu pinosu mentioned this issue Nov 22, 2022
Merged
Repository owner moved this from 📋 Unsorted Backlog to ✅ Done in wasmd backlog Dec 9, 2022
@alpe alpe removed this from wasmd backlog Mar 3, 2023
@Lockwarr Lockwarr mentioned this issue Apr 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pinosu pinosu

Labels
None yet
Projects
None yet
Milestone
v0.31.0
Development

Successfully merging a pull request may close this issue.

Remove genesis msgs CosmWasm/wasmd
3 participants
@alpe @ethanfrey @pinosu