Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TabsController transition sets alpha of views to 1.0 #1022

Closed
andrewc94 opened this issue Jan 14, 2018 · 10 comments
Closed

TabsController transition sets alpha of views to 1.0 #1022

andrewc94 opened this issue Jan 14, 2018 · 10 comments

Comments

@andrewc94
Copy link

I'm using a control which has a set of invisible labels and set of visible labels. During my first transition to a view controller which contains this control, all the labels are visible when half should be invisible. I'm not sure what's causing this but using a UITabBarController does not have this problem.

screen shot 2018-01-14 at 2 55 24 pm

- What it should look like:

screen shot 2018-01-14 at 3 27 33 pm

@daniel-jonathan
Copy link
Member

Thank you for sharing this issue. I am going to investigate it tonight. In the meantime, if you have a sample project that reproduces the issue, that would be great.

@andrewc94
Copy link
Author

Here you go, switch between the tabs to see the issue.
Test.zip

@daniel-jonathan
Copy link
Member

Thank you! @andrewc94

@andrewc94
Copy link
Author

Also not sure if this is helpful, but here's the stack trace where the label's alpha is set to 1 from 0 during the transition.

screen shot 2018-01-15 at 2 54 53 pm

@daniel-jonathan
Copy link
Member

Hey sorry for any delays with this issue. @adamdahan let's both take a look at this one.

@adamdahan
Copy link
Contributor

@andrewc94 Stacktrace very useful thank you. Will look more into this tonight :)

@adamdahan
Copy link
Contributor

adamdahan commented Jan 18, 2018

@andrewc94

I have confirmed the issue in the latest version of Material and found the root cause of the issue with your help. I will confirm a fix with @DanielDahan and make sure this is addressed in the next release. The fix will address issues #853, CosmicMind/Motion#16 aswell.

Will keep this ticket open until it's fully resolved. Thank you for the test project and stacktrace 👍

@andrewc94
Copy link
Author

@adamdahan
Thank you so much!! Would it be possible to give a high level explanation of what was going on?

@daniel-jonathan
Copy link
Member

daniel-jonathan commented Jan 19, 2018

@adamdahan I fixed the alpha issue. We will make a push later today.

@daniel-jonathan
Copy link
Member

@andrewc94 Thank you for sharing this issue, thank you @adamdahan for discovering the solution. The fix is in development and will be pushed later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants