Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White color turns blue on Pod Update #1199

Closed
AdieOlami opened this issue Jan 7, 2019 · 9 comments
Closed

White color turns blue on Pod Update #1199

AdieOlami opened this issue Jan 7, 2019 · 9 comments

Comments

@AdieOlami
Copy link

Hi, I incorporated material in most of my UI components and I updated my pod to use this

pod 'Material', :git => 'https://github.com/CosmicMind/Material.git', :commit => '4ab1b08c3365a00f409a210162ae72ed8425f299' when I run the application, all my white color turns blue and I cannot seem to understand why.

@OrkhanAlikhanov
Copy link
Contributor

Hey! Most likely it happens due to theming #1115. You can add Theme.isEnabled = false to your AppDelegate.swift to disable it. See also #1174.

@AdieOlami
Copy link
Author

when I disabled the Theme, the navigation bar color turns black which is supposed to be white

@AdieOlami
Copy link
Author

if I set Theme.light.primary = .white, the navigation becomes white and my UIButton colors become white too. while the button is supposed to be black

@OrkhanAlikhanov
Copy link
Contributor

OrkhanAlikhanov commented Jan 7, 2019

when I disabled the Theme, the navigation bar color turns black which is supposed to be white

Hmm, that's a regression. Before default color was .white, currently it's expected to be set by theming, but when theming is disabled it sets noting my default.

You can check the removed line:
https://github.com/CosmicMind/Material/pull/1115/files#diff-b2493560b26f2b7a682624a8d8178015L171

@OrkhanAlikhanov
Copy link
Contributor

Unfortunately, the best thing is that you disable theming and set white color on navigation bar manually.

@AdieOlami
Copy link
Author

how can I set that globally for material so that it reflects on all my navigation

@OrkhanAlikhanov
Copy link
Contributor

OrkhanAlikhanov commented Jan 7, 2019

Theme.light.primary = .white should've done the trick (providing that you do it before Theme.current is accessed). Which buttons turned into white in buttons navigationItem or others? Did you explicitly set black color on them?

@AdieOlami
Copy link
Author

The background color of the FlatButton has refused to change to a black color but instead remained white

@AdieOlami
Copy link
Author

I had to set the tintcolor of each button. I would work with that now. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants