Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

viewWillAppear etc. is not called MotionTransition #24

Closed
OrkhanAlikhanov opened this issue Jan 7, 2018 · 3 comments
Closed

viewWillAppear etc. is not called MotionTransition #24

OrkhanAlikhanov opened this issue Jan 7, 2018 · 3 comments
Assignees
@daniel-jonathan
Labels
high priority investigate motion regression waiting on support

Comments

@OrkhanAlikhanov
Copy link
Contributor

As of 1.3.2 viewWillAppear(_:), viewWillDisappear(_:), viewDidAppear(_:), and viewDidDisappear(_:) are not invoked when we make transitions through MotionTransition since you removed calls to beginAppearanceTransition(_:animated:) and endAppearanceTransition() in commit 6b95e48

Material's TabsController is a victim of this change. I am not getting viewWillAppear(_:)-s anymore which my child view controllers heavily rely on
@daniel-jonathan daniel-jonathan self-assigned this Jan 7, 2018
@daniel-jonathan
Copy link
Member

I am going to make a fix for this today. Sorry about that. I was concerned about this happened.

@daniel-jonathan daniel-jonathan mentioned this issue Jan 7, 2018
Closed
@OrkhanAlikhanov
Copy link
Contributor Author

No worries :) Thank you for your support!

@daniel-jonathan
Copy link
Member

Please find a correct fix for this in Material 2.13.3 and Motion 1.3.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-jonathan daniel-jonathan

Labels
high priority investigate motion regression waiting on support
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daniel-jonathan @OrkhanAlikhanov