Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove x/params #694

Closed
dimiandre opened this issue May 25, 2023 · 3 comments · Fixed by #708
Closed

remove x/params #694

dimiandre opened this issue May 25, 2023 · 3 comments · Fixed by #708
Milestone
SDK v47

Comments

@dimiandre
Copy link
Member

Many modules we have still depend on x/params

We should remove all references to it and implement their own params store for each module.

an example on how to do is here cosmos/cosmos-sdk#12363
@dimiandre dimiandre added this to the sdk47 milestone May 25, 2023
@dimiandre
Copy link
Member Author

another place to take inspiration from

ef6bc6b

@Reecepbcups
Copy link
Contributor

Thanks! Yea I was hoping to have this done in my cleanup branch this week. got pushed back for the v15 upgrade though

that + the migration is the last major milestone left other than adding more ictest & shipping

@Reecepbcups Reecepbcups mentioned this issue May 25, 2023
Closed
@Reecepbcups Reecepbcups mentioned this issue Jun 6, 2023
Merged
@Reecepbcups
Copy link
Contributor

Completed in other merged PRs for each module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
SDK v47
Development

Successfully merging a pull request may close this issue.

[v47] GlobalFee Params Migration Rewrite CosmosContracts/juno
2 participants
@dimiandre @Reecepbcups