Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/european locale support #40

Closed
wants to merge 3 commits into from
Closed

Bugfix/european locale support #40

wants to merge 3 commits into from

Conversation

celiluysal
Copy link

@celiluysal celiluysal commented Jan 16, 2023 •
edited
Loading

This pr fixes #13

@efguydan
Copy link
Member

Hey @celiluysal, Thanks a lot for the PR.

As this issue isn't introduced by the library, we feel it should not be fixed by it.
Usages of the library can add the code suggested by the S/O thread linked in #13 to serve as a fix.

Therefore closing this one.

@efguydan efguydan closed this Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does not work with French/European locales
2 participants
@celiluysal @efguydan