Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background Is Darker Than Expected #226

Closed
Phoupraw opened this issue Nov 18, 2023 · 0 comments
Closed

Background Is Darker Than Expected #226

Phoupraw opened this issue Nov 18, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@Phoupraw
Copy link

Describe the bug
Background of CottonInventoryScreen is darker than vanilla screen's.

To Reproduce
Steps to reproduce the behavior:

  1. Create a CottonInventoryScreen.
  2. Open it.
  3. You can see the background is darker.

Expected behavior Optional
It should be as dark as vanilla.

Screenshots Optional
Vanilla screen:
2023-11-18_22 44 55
CottonInventoryScreen:
2023-11-18_22 44 57

Version of the mods:

  • emi 1.0.24+1.20.2+fabric
  • fabric-api 0.90.7+1.20.2
  • fabric-api-base 0.4.33+fce67b32a0
  • fabric-api-lookup-api-v1 1.6.42+b1792f7da0
  • fabric-biome-api-v1 13.0.14+b1792f7da0
  • fabric-block-api-v1 1.0.12+73761d2ea0
  • fabric-block-view-api-v2 1.0.1+73761d2ea0
  • fabric-blockrenderlayer-v1 1.1.43+f4b7e424a0
  • fabric-client-tags-api-v1 1.1.4+86b12645a0
  • fabric-command-api-v1 1.2.37+f71b366fa0
  • fabric-command-api-v2 2.2.16+b1792f7da0
  • fabric-commands-v0 0.2.54+df3654b3a0
  • fabric-containers-v0 0.1.75+df3654b3a0
  • fabric-content-registries-v0 5.0.5+b1792f7da0
  • fabric-convention-tags-v1 1.5.8+b1792f7da0
  • fabric-crash-report-info-v1 0.2.20+f4b7e424a0
  • fabric-data-generation-api-v1 13.1.5+b1792f7da0
  • fabric-dimensions-v1 2.1.57+b1792f7da0
  • fabric-entity-events-v1 1.5.26+b1792f7da0
  • fabric-events-interaction-v0 0.6.10+b1792f7da0
  • fabric-events-lifecycle-v0 0.2.69+df3654b3a0
  • fabric-game-rule-api-v1 1.0.42+a44e16a6a0
  • fabric-gametest-api-v1 1.2.16+b1792f7da0
  • fabric-item-api-v1 2.1.33+b1792f7da0
  • fabric-item-group-api-v1 4.0.15+e3d2bf3fa0
  • fabric-key-binding-api-v1 1.0.38+f4b7e424a0
  • fabric-keybindings-v0 0.2.36+df3654b3a0
  • fabric-lifecycle-events-v1 2.2.27+b1792f7da0
  • fabric-loot-api-v2 2.1.1+3ba460fba0
  • fabric-message-api-v1 6.0.2+e3d2bf3fa0
  • fabric-mining-level-api-v1 2.1.55+f4b7e424a0
  • fabric-model-loading-api-v1 1.0.6+b1792f7da0
  • fabric-models-v0 0.4.5+9386d8a7a0
  • fabric-networking-api-v1 3.0.11+bff13c85a0
  • fabric-object-builder-api-v1 12.1.2+2ff98d3ba0
  • fabric-particles-v1 1.1.4+f4b7e424a0
  • fabric-recipe-api-v1 2.0.8+52b3ebe5a0
  • fabric-registry-sync-v0 4.0.6+b1792f7da0
  • fabric-renderer-api-v1 3.2.1+2034447ca0
  • fabric-renderer-indigo 1.5.1+2034447ca0
  • fabric-renderer-registries-v1 3.2.49+df3654b3a0
  • fabric-rendering-data-attachment-v1 0.3.39+73761d2ea0
  • fabric-rendering-fluids-v1 3.0.30+f4b7e424a0
  • fabric-rendering-v0 1.1.52+df3654b3a0
  • fabric-rendering-v1 3.0.11+b1792f7da0
  • fabric-resource-conditions-api-v1 2.3.10+e3d2bf3fa0
  • fabric-resource-loader-v0 0.11.12+b1792f7da0
  • fabric-screen-api-v1 2.0.12+b1792f7da0
  • fabric-screen-handler-api-v1 1.3.41+b1792f7da0
  • fabric-sound-api-v1 1.0.14+f4b7e424a0
  • fabric-transfer-api-v1 3.3.10+bb1ee60ea0
  • fabric-transitive-access-wideners-v1 5.0.3+fce67b32a0
  • fabricloader 0.14.24
  • jankson 6.0.0+j1.2.3
  • java 17
  • libgui 9.0.0+1.20.2
  • libninepatch 1.2.0
  • minecraft 1.20.2
  • modmenu 8.0.0
  • team_reborn_energy 3.0.0
  • trifle_industry ${version}

Additional context Optional
Both CottonInventoryScreen#paint and Screen#render call Screen#renderBackground. The method is called twice in total, so CottonInventoryScreen is darker.

@Phoupraw Phoupraw added the bug Something isn't working label Nov 18, 2023
@Juuxel Juuxel closed this as completed in 8ac7945 Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant