Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] - WORKAROUND IN PLACE | Attempting to push an update after a previous push fails #1

Closed
1 of 2 tasks
Crash0v3r1de opened this issue Dec 16, 2022 · 2 comments
Closed
1 of 2 tasks
Assignees
Labels
bug Something isn't working

Comments

@Crash0v3r1de
Copy link
Owner

Crash0v3r1de commented Dec 16, 2022

Web request when the fleet push to Balena does not return started = true.

Do not have a capture of the return that's failing currently but it looks like it does not actually add the update to the fleet from the return.

Fixes

  • Lazy work around could be forcing app restart upon successful push.
  • Correct fix would be to capture until the failed request and break down why it failed - this'll take a while.

https://github.com/Crash0v3r1de/BalenaNebraUpdater/blob/master/Program.cs#L54
^^ Line that fires with the incorrect request return ^^

@Crash0v3r1de Crash0v3r1de added the bug Something isn't working label Dec 16, 2022
@Crash0v3r1de Crash0v3r1de self-assigned this Dec 16, 2022
@Crash0v3r1de
Copy link
Owner Author

Workaround Commit: d759b94
Keeping this open as the simple restart is the current work around. I want to get a good capture and reverse the second push web request's to see what changed and then replicate that in this project so it does not need to restart itself at all.

@Crash0v3r1de Crash0v3r1de changed the title [Bug] Attempting to push an update after a previous push fails [Bug] - WORKAROUND IN PLACE | Attempting to push an update after a previous push fails Feb 14, 2023
@Crash0v3r1de
Copy link
Owner Author

seems the restart code is working better than I thought. I'll keep it as a fix as it seems Balena API is also being quite stable over the last couple months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant