Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: release workflow #1013

Merged
merged 1 commit into from
Oct 12, 2023
Merged

fix: release workflow #1013

merged 1 commit into from
Oct 12, 2023

Conversation

0xmad
Copy link
Member

@0xmad 0xmad commented Oct 12, 2023

Explanation

This PR added sign step for types and zk package publish workflow.

Related Issues

N/A

Screenshots

N/A

Manual Testing Steps

N/A

Pre-Merge Checklist

Assignees Checklist

  • PR template is filled out
  • Pre-commit and pre-push hook checks are passed
  • E2E tests are passed locally
  • IF this PR fixes a bug, a test that would have caught the bug has been added
  • PR is linked to the appropriate GitHub issue
  • PR has been added to the appropriate release Milestone

Reviewers Checklist

  • Manual testing checked and passed.

@0xmad 0xmad added the DevOps Troubleshooting DevOps issues label Oct 12, 2023
@0xmad 0xmad added this to the v0.5.0 milestone Oct 12, 2023
@0xmad 0xmad self-assigned this Oct 12, 2023
@0xmad 0xmad merged commit eafc7ad into main Oct 12, 2023
10 checks passed
@0xmad 0xmad deleted the fix/release-workflow branch October 12, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xisk 0xisk Awaiting requested review from 0xisk 0xisk is a code owner

@AtHeartEngineer AtHeartEngineer Awaiting requested review from AtHeartEngineer AtHeartEngineer is a code owner

Assignees

@0xmad 0xmad

Labels
DevOps Troubleshooting DevOps issues
Projects
Crypt-Keeper Extension
Status: ✅ Done
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
1 participant
@0xmad