Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: import identity integration #993

Merged
merged 7 commits into from
Oct 12, 2023
Merged

feat: import identity integration #993

merged 7 commits into from
Oct 12, 2023

Conversation

0xmad
Copy link
Member

@0xmad 0xmad commented Oct 10, 2023

Explanation

Details are below:

  • Integrate import identity
  • Simplify provider and content script integration
  • Support router history between connect, create and import pages

Related Issues

Blocked by #990
Related to #906

Screenshots

Expand

image
image

Manual Testing Steps

  1. Try to import identity from create identity screen
  2. Try to import identity from connect identity screen

Pre-Merge Checklist

  • PR template is filled out
  • Pre-commit and pre-push hook checks are passed
  • E2E tests are passed locally
  • IF this PR fixes a bug, a test that would have caught the bug has been added
  • PR is linked to the appropriate GitHub issue
  • PR has been added to the appropriate release Milestone

PR template source from github.com/MetaMask

@0xmad 0xmad added the 🌱 new feature Troubleshooting new feature issues label Oct 10, 2023
@0xmad 0xmad added this to the v0.6.0 milestone Oct 10, 2023
@0xmad 0xmad self-assigned this Oct 10, 2023
@0xmad 0xmad mentioned this pull request Oct 11, 2023
Merged
9 tasks
@0xmad 0xmad force-pushed the feature/import-identity-integration branch 2 times, most recently from 85535a6 to 8af814e Compare October 11, 2023 21:50
0xisk
0xisk approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@0xisk 0xisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @0xmad!

0xmad added 7 commits October 12, 2023 08:49
@0xmad
feat: import identity
697f22a 
- [x] Add method for import and save identity
- [x] Update identity list to support imported identities
- [x] Update history and notification for imported identities
@0xmad
chore: revert lock changes
1a25571
@0xmad
feat: import identity
3183f38 
- [x] Add method for import and save identity
- [x] Update identity list to support imported identities
- [x] Update history and notification for imported identities
@0xmad
chore: revert lock changes
c1cf507
@0xmad
feat: import identity
17a30ea 
- [x] Add method for import and save identity
- [x] Update identity list to support imported identities
- [x] Update history and notification for imported identities
@0xmad
feat: import identity integration
fc5f3a4 
- [x] Integrate import identity
- [x] Simplify provider and content script integration
- [x] Support router history between connect, create and import pages
@0xmad
feat: validation logic for import identity
8ed94ef
@0xmad 0xmad force-pushed the feature/import-identity-integration branch from 8af814e to 8ed94ef Compare October 12, 2023 13:49
@0xmad 0xmad enabled auto-merge (squash) October 12, 2023 13:50
@0xmad 0xmad merged commit d5eb868 into main Oct 12, 2023
10 checks passed
@0xmad 0xmad deleted the feature/import-identity-integration branch October 12, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xisk 0xisk 0xisk approved these changes

@AtHeartEngineer AtHeartEngineer Awaiting requested review from AtHeartEngineer AtHeartEngineer is a code owner

Assignees

@0xmad 0xmad

Labels
🌱 new feature Troubleshooting new feature issues
Projects
Crypt-Keeper Extension
Status: ✅ Done
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@0xmad @0xisk