You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have searched for an existing bug report for this issue.
I am using the latest available version of AMP.
my operating system is up-to-date.
Intended Action
AMP's Minecraft module (and I assume others but have not tested) Send POST Request task does not sanitize it's json. When sending through an in-game chat message to said task, if the message contains quotes the json that is sent is invalid.
Example;
{"USER":"MsVoxxie","MESSAGE":""test""}
would return SyntaxError: Unexpected token t in JSON at position 31
Expected Behaviour
I would expect AMP to escape the jsons payload as it is unreasonable to expect a user to send \"Test!\" as a message.
Actual Behaviour
AMP does not escape outgoing json data, leading to broken formatting.
Reproduction
Set up an event listener for player message and attach a send post request task to said event and send the message data as the payload, if the message contains quotes the json sends incorrectly.
The text was updated successfully, but these errors were encountered:
Operating System
Ubuntu 23.04
AMP Version and Build Date
2.6.0.6 - 20241120.1
AMP Release Stream
Mainline
I confirm that
Intended Action
AMP's Minecraft module (and I assume others but have not tested) Send POST Request task does not sanitize it's json. When sending through an in-game chat message to said task, if the message contains quotes the json that is sent is invalid.
Example;
{"USER":"MsVoxxie","MESSAGE":""test""}
would return
SyntaxError: Unexpected token t in JSON at position 31
Expected Behaviour
I would expect AMP to escape the jsons payload as it is unreasonable to expect a user to send
\"Test!\"
as a message.Actual Behaviour
AMP does not escape outgoing json data, leading to broken formatting.
Reproduction
Set up an event listener for player message and attach a send post request task to said event and send the message data as the payload, if the message contains quotes the json sends incorrectly.
The text was updated successfully, but these errors were encountered: