Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differ should delete unused files from differ_backup #19

Open
pintassilgo opened this issue Mar 19, 2023 · 5 comments
Open

Differ should delete unused files from differ_backup #19

pintassilgo opened this issue Mar 19, 2023 · 5 comments

Comments

@pintassilgo
Copy link

I noticed my differ_backup folder is full of files, but currently I don't have not even a single comparison open in session.

Differ should delete each file as soon as they are no longer needed, when they are removed from session.

@Alexey-T
Copy link
Collaborator

when they are removed from session.

we cannot detect this moment. but we can detect on_close - when any tab is closed. it is moment when user closes differ's pair-tab or individual tabs.

@pintassilgo
Copy link
Author

Right, on_close is fine, that's what I meant when I said "session". Because when a tab is closed it's removed from session, even if session actually isn't updated instantly.

@Alexey-T
Copy link
Collaborator

ToDo for me.

@Alexey-T
Copy link
Collaborator

I failed to add it. I added deletion of temp-files, but it was activated too early - even when separate tabs are closed to make the Differ-tab. so some blocking of early deletion is needed. I am stuck

@pintassilgo
Copy link
Author

pintassilgo commented Mar 27, 2023

In this case, maybe the cleanup can be done in other moment, like when the user attempts to close Cuda entirely. Differ would remove unused files from its backup folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants