This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge cyber into fork
IQTLabs#285 styling ring menu
merge cyber into local
Feature note taking
… state doesn't fail test
The tooltip prepopulates with a note if there is one as well
merge updated dependencies
Feature note taking
Codecov Report
@@ Coverage Diff @@
## master #415 +/- ##
=========================================
+ Coverage 82.62% 82.8% +0.17%
=========================================
Files 28 29 +1
Lines 823 849 +26
=========================================
+ Hits 680 703 +23
- Misses 143 146 +3
Continue to review full report at Codecov.
|
rashley-iqt
suggested changes
Jul 16, 2019
rashley-iqt
suggested changes
Jul 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please correct linting errors as they are causing CI to fail.
- I think it would be better to hide the detail panel on the initial load until there is something to show the details of.
- I think the save/delete buttons should be:
- centered
- black and white
- consistent with the size/style of the other icons
- Visually offset the notes area from the imported data, maybe something like a horizontal rule?
- Once a note is entered, a user has to click off of the node and then back on to see the note.
- Please make it visually clear that the title and note areas are text areas are text fields. Try to use the same style as other text fields
- make the notes entry area fit the width of the tooltip and, if possible, multi-line
- the tagging feature doesn't seem to work in any expected way. Hide this for now and we will add this in a subsequent PR.
- make the notes entry area fit the width of the tooltip and multi-line - removed tagging feature - hide the detail panel on the initial load until there is something to show the details of - make tooltip adhere to CRViz style
Data annotation IQTLabs#415
Addressed these issues
|
rashley-iqt
approved these changes
Jul 17, 2019
This was referenced Jul 17, 2019
Closed
hopetambala
added a commit
to hopetambala/CRviz
that referenced
this pull request
Jul 18, 2019
feat(annotation): Merge pull request IQTLabs#415 from hopetambala/master
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
What does this pr accomplish and why should it be integrated?
Implement a note-taking feature that is a panel on the right-hand side that doubles as replacing the tooltip feature (found in d3). It has the ability to create a note with a title, labels, and note content. It then saves that note for a user to have the ability to export the notes and is retrievable on upload dataset.
Checklist
_Put an x in the boxes that apply. _
[x ]Lint and unit tests pass locally with my changes
[x ] I have added tests that prove my changes work (if applicable)
[x ]I have added or updated necessary documentation (if appropriate)
Additional comments
Is there anything else you want us to know?
Turns off the d3 mouseover
adds a setPosition action to the controls reducer (for a future use)