From fda04044a4a36e3bded90c25f5dfda5c8f51e8fc Mon Sep 17 00:00:00 2001 From: John Bodley <4567245+john-bodley@users.noreply.github.com> Date: Thu, 31 Aug 2023 13:50:34 -0700 Subject: [PATCH] fix: Handle Python date format for GENERIC_CHART_AXES feature (#25135) --- superset/connectors/sqla/models.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/superset/connectors/sqla/models.py b/superset/connectors/sqla/models.py index 09f5815e23741..cdebe8724cf64 100644 --- a/superset/connectors/sqla/models.py +++ b/superset/connectors/sqla/models.py @@ -991,11 +991,13 @@ def adhoc_column_to_sqla( # pylint: disable=too-many-locals time_grain = col.get("timeGrain") has_timegrain = col.get("columnType") == "BASE_AXIS" and time_grain is_dttm = False + pdf = None if col_in_metadata := self.get_column(expression): sqla_column = col_in_metadata.get_sqla_col( template_processor=template_processor ) is_dttm = col_in_metadata.is_temporal + pdf = col_in_metadata.python_date_format else: sqla_column = literal_column(expression) if has_timegrain or force_type_check: @@ -1012,7 +1014,7 @@ def adhoc_column_to_sqla( # pylint: disable=too-many-locals if is_dttm and has_timegrain: sqla_column = self.db_engine_spec.get_timestamp_expr( col=sqla_column, - pdf=None, + pdf=pdf, time_grain=time_grain, ) return self.make_sqla_column_compatible(sqla_column, label)