Allow no_std and fewer dependencies
#9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeddenlea
force-pushed
the
main
branch
2 times, most recently
from
2321553
to
a1ef2b9
Compare
AlbertoSvg
reviewed
Oct 4, 2024
We need to be able to use this crate in a `no_std` context. Additionally, we cannot make use of the `sha2` or `sha3` crates. This commit adds a couple of features: `std`, which is enabled by default, must be specified in order to use `write_keypair_to_file`. This was actually the only real dependency on `std` outside of tests. I've split the `bbsplus` feature up. `min_bbs` enables the algorithms, but does not actually implement either the Sha256 or Shake256 schemes. I've also bumped group to 0.13, which should be nonbreaking because bls12_381_plus 0.8.18 already requires it.
|
@jeddenlea I was thinking of releasing these changes as soon as the ones in bls12_381_plus are accepted and a new version is released, so that I can update the dependency in Zkryptium and then make a single release. What do you think? |
|
Hey @AlbertoSvg, that sounds good to me. |
|
Digging into this deeper, it turns out there's still some std links that I missed. I will need to come back to this with something probably a bit more involved. It'll be a couple weeks though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to be able to use this crate in a
no_stdcontext. Additionally, we cannot make use of thesha2orsha3crates. This commit adds a couple of features:std, which is enabled by default, must be specified in order to usewrite_keypair_to_file. This was actually the only real dependency onstdoutside of tests.I've split the
bbsplusfeature up.min_bbsenables the algorithms, but does not actually implement either the Sha256 or Shake256 schemes.Just as written, this cannot yet compile into a
no_stdcontext because bls12_381_plus'sno_stdsupport is broken, but I'm trying to resolve that in mikelodder7/bls12_381_plus#5.I've also bumped group to 0.13, which should be nonbreaking because bls12_381_plus 0.8.18 already requires it.