DEFI: In the fuzz test, my code did not test mintDsc, but the terminal consistently reported that my test failed. The reason is as follows: [FAIL: invariant_protocolMustHaveMoreValueThatTotalSupplyDollars persisted failure revert]

[jupiter-Pulin]

error：

[Sequence]
sender=0x0000000000000000000000005Af6C5814afc47a4 addr=[test/fuzz/failOnRevert/StopOnRevertHandler.t.sol:StopOnRevertHandler]0x2e234DAe75C793f67A35089C9d99245E1C58470b calldata=mintDsc(uint256) args=[2736290469984690291777896978586204365690728779724471690417738340261494 [2.736e69]]

StopOnRevertInvariants:

// SPDX-License-Identifier: MIT

pragma solidity ^0.8.19;

import {Test, console} from "forge-std/Test.sol";
import {StdInvariant} from "forge-std/StdInvariant.sol";
import {DeployDSC} from "../../../script/DeployDSC.s.sol";

import {DecentralizedStableCoin} from "../../../src/DecentalizedStableCoin.sol";
import {DSCEngine} from "../../../src/DSCEngine.sol";
import {HelperConfig} from "../../../script/HelperConfing.s.sol";
import {ERC20Mock} from "../../mock/ERC20Mock.sol";
import {MockV3Aggregator} from "../../mock/MockV3Aggregator.sol";
import {StopOnRevertHandler} from "./StopOnRevertHandler.t.sol";

contract StopOnRevertInvariants is StdInvariant, Test {
    DSCEngine public dsce;
    DecentralizedStableCoin public dsc;
    HelperConfig public config;

    address public weth;
    address public wbtc;
    address public wethPricefeeds;
    address public wbtcPricefeeds;
    StopOnRevertHandler handler;

    function setUp() external {
        DeployDSC deployer = new DeployDSC();
        (dsc, dsce, config) = deployer.run();
        (wethPricefeeds, wbtcPricefeeds, weth, wbtc, ) = config
            .activeNetWorkConfig();
        handler = new StopOnRevertHandler(dsce, dsc);
        targetContract(address(handler));
    }


    function invariant_protocolMustHaveMoreValueThatTotalSupplyDollars()
        public
        view
    {
        uint256 totalDscVal = dsc.totalSupply();

        uint256 wethAmount = ERC20Mock(weth).balanceOf(address(dsce));
        uint256 wbtcAmount = ERC20Mock(wbtc).balanceOf(address(dsce));
        uint256 wethAmountInUSD = dsce.getTokenToUsdPrice(weth, wethAmount);
        uint256 wbtcAmountInUSD = dsce.getTokenToUsdPrice(wbtc, wbtcAmount);
        console.log("wethAmountInUSD: ", wethAmountInUSD);
        console.log("wbtcAmountInUSD: ", wbtcAmountInUSD);
        console.log("totalDSC: ", totalDscVal);

        assert(wbtcAmountInUSD + wethAmountInUSD >= totalDscVal);
    }
}

StopOnRevertHandler:

// // SPDX-License-Identifier: MIT

pragma solidity ^0.8.19;

import {EnumerableSet} from "@openzeppelin/contracts/utils/structs/EnumerableSet.sol";
import {Test} from "forge-std/Test.sol";
// import { ERC20Mock } from "@openzeppelin/contracts/mocks/ERC20Mock.sol"; Updated mock location
import {ERC20Mock} from "../../mock/ERC20Mock.sol";

import {MockV3Aggregator} from "../../mock/MockV3Aggregator.sol";
import {DSCEngine, AggregatorV3Interface} from "../../../src/DSCEngine.sol";
import {DecentralizedStableCoin} from "../../../src/DecentalizedStableCoin.sol";
import {console} from "forge-std/console.sol";

contract StopOnRevertHandler is Test {
    using EnumerableSet for EnumerableSet.AddressSet;

    // Deployed contracts to interact with
    DSCEngine public dscEngine;
    DecentralizedStableCoin public dsc;
    MockV3Aggregator public ethUsdPriceFeed;
    MockV3Aggregator public btcUsdPriceFeed;
    ERC20Mock public weth;
    ERC20Mock public wbtc;
    // Ghost Variables
    uint96 public constant MAX_DEPOSIT_SIZE = type(uint96).max;

    constructor(DSCEngine _dscEngine, DecentralizedStableCoin _dsc) {
        dscEngine = _dscEngine;
        dsc = _dsc;
        address[] memory collateralTokens = dscEngine.getCollateralTokenAddr();
        weth = ERC20Mock(collateralTokens[0]);
        wbtc = ERC20Mock(collateralTokens[1]);
        ethUsdPriceFeed = MockV3Aggregator(
            dscEngine.getCollateralTokenPriceFeed(address(weth))
        );
        btcUsdPriceFeed = MockV3Aggregator(
            dscEngine.getCollateralTokenPriceFeed(address(wbtc))
        );
    }

    // FUNCTOINS TO INTERACT WITH

    ///////////////
    // DSCEngine //
    ///////////////
    function mintAndDepositCollateral(
        uint256 collateralSeed,
        uint256 amountCollateral
    ) public {
        // must be more than 0
        amountCollateral = bound(amountCollateral, 1, MAX_DEPOSIT_SIZE);
        ERC20Mock collateral = _getCollateralFromSeed(collateralSeed);

        vm.startPrank(msg.sender);
        collateral.mint(msg.sender, amountCollateral);
        collateral.approve(address(dscEngine), amountCollateral);
        dscEngine.depositCollateralized(address(collateral), amountCollateral);
        vm.stopPrank();
    }

    function redeemCollateral(
        uint256 collateralSeed,
        uint256 amountCollateral
    ) public {
        ERC20Mock collateral = _getCollateralFromSeed(collateralSeed);
        uint256 maxCollateral = dscEngine.getcollateralDeposited(
            address(collateral),
            msg.sender
        );

        amountCollateral = bound(amountCollateral, 0, maxCollateral);
        //vm.prank(msg.sender);
        if (amountCollateral == 0) {
            return;
        }
        vm.prank(msg.sender);
        dscEngine.redeemCollateralized(address(collateral), amountCollateral);
    }

    // function burnDsc(uint256 amountDsc) public {
    //     // Must burn more than 0
    //     amountDsc = bound(amountDsc, 0, dsc.balanceOf(msg.sender));
    //     if (amountDsc == 0) {
    //         return;
    //     }
    //     vm.startPrank(msg.sender);
    //     dsc.approve(address(dscEngine), amountDsc);
    //     dscEngine.burnDsc(amountDsc);
    //     vm.stopPrank();
    // }

    function _getCollateralFromSeed(
        uint256 collateralSeed
    ) private view returns (ERC20Mock) {
        if (collateralSeed % 2 == 0) {
            return weth;
        } else {
            return wbtc;
        }
    }
}

[jupiter-Pulin]

The second question is, why did Patrick mention mintDsc in the course, but not include this code in the actual StopOnRevert?

[EngrPips]

Have you tried running forge clean, deleting the cache folder, and then running foundryup? Then, retry the process. I don't have the code for StopOnRevert in my codebase, and I am unsure why that is.

[jupiter-Pulin]

I followed your advice and ran forge clean in the terminal, then set fail_on_revert = true. Now everything is running successfully!!! But I'm not sure why.

[EngrPips]

It could be an issue with Foundry caching. I am glad it is working as you expected.

[jupiter-Pulin]

but I still don't understand why mindDSC not in the actual StopOnRevert.

[EngrPips]

If you think it is supposed to be there and Patrick didn't put it you can put it and play with stuffs.